From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04C2346AEE2 for ; Fri, 15 May 2026 10:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778842325; cv=none; b=Qd71qfus//Yh+uOQWFBnmm7RCDPRk/lpTmoco/ysVBNT+o3AMS+Imw3sX3b0bcMFlHwnONdgnDhG0jJVnT9En1HJ+JW1Cgbx56MP9mtZxWRfZKlU7J/Kp5k4tr62u5CcfFgzKEXB2Z3+Du/y+1YQWut2Jt6Ic4lWHB1+hRhh9ak= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778842325; c=relaxed/simple; bh=EkWP4MQXRsxUe7DwYNJKZnTlyJkySaF5yIh8AiOKcH8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=qzXEFe6UD24Mcc1He9lacFu6DynvLlMW/6fBI3BWrOHJK+mSrsWIJXS0rPWqzATb7p/W/ALVJSLb2PBtb/PHD5jVFrKjCajtvms2zgvhQm3nR6i3fPtXN3fFcxxxlgyJ2VfS4ZLHPDpc8tEbdUe3vE6ninnF3RSGLD8o52JfjUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tfrD7YWe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tfrD7YWe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 572DCC2BCB0; Fri, 15 May 2026 10:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778842324; bh=EkWP4MQXRsxUe7DwYNJKZnTlyJkySaF5yIh8AiOKcH8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=tfrD7YWel4byQer4Me+IncdaVdOdzb6CBW767Q6R//9uVpcXz2haV8tGJkOrsGddb 9zSBLc/TuwVr7lskmwE0tf+fiVU4d044NCOP6GaASpdBGSPAl1LerBxgwPTHTL2rw8 X4jwLazud/ZWVLyOwXzjjPZrmwPqsSgEiFWUPz3Ea+6MHDblw7HedoBR4J8ZQWfIok 7eVCxEXkgfl9ErpNIJNCWU/74v6WRlu+rvpyt/RmTGhbeyFua4QrRX1KZufRrkmXP3 lT8fUuodeagUsVowYQA9gvDr/kYY014lRnYdzMnDInrKj/LGnOL7BERfKzRYnpHLL7 ObdDFFielVVDA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v6 03/11] dt-bindings: mfd: add documentation for S2MU005 PMIC Reply-To: sashiko-reviews@lists.linux.dev To: "Kaustabh Chakraborty" Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org, krzk+dt@kernel.org In-Reply-To: <20260515-s2mu005-pmic-v6-3-1979106992d4@disroot.org> References: <20260515-s2mu005-pmic-v6-3-1979106992d4@disroot.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 15 May 2026 10:52:03 +0000 Message-Id: <20260515105204.572DCC2BCB0@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The `$ref` for the `flash` child node schema is missing a trailing = `#`. -- commit af977d3436c72dabe8294eb2a16ebaa919887d37 Author: Kaustabh Chakraborty dt-bindings: mfd: add documentation for S2MU005 PMIC Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC, and flash and RGB LED controllers. This commit adds the device tree binding documentation for the S2MU005 PMIC and its supported sub-devices. > diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pmic.y= aml b/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pmic.yaml > new file mode 100644 > index 0000000000000..0e6afb7d2017b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/samsung,s2mu005-pmic.yaml [ ... ] > +properties: > + compatible: > + const: samsung,s2mu005-pmic > + > + flash: > + $ref: /schemas/leds/samsung,s2mu005-flash.yaml Is this missing a trailing `#`? Device tree schema conventions and tooling expect file references to end with `#` to explicitly reference the root of the target schema document.=20 Other references in this file, such as the muic node, include it. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260515-s2mu005-pm= ic-v6-0-1979106992d4@disroot.org?part=3D3