Re: [PATCH 5/5] phy: qcom-qusb2: add QUSB2 support for ipq5210

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message incorrectly describes the patch contents. It claims to add an init sequence for 'Super Speed ports', but the patch actually modifies the QUSB2 PHY driver, which is responsible for USB 2.0 (High Speed / Full Speed / Low Speed) ports. Furthermore, the patch does not introduce a new initialization sequence; it simply maps the new `qcom,ipq5210-qusb2-phy` compatible string to the existing `ipq6018_phy_cfg` data.
--

commit a327055af09a1520cf8f88735b110f1df7674e64
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

phy: qcom-qusb2: add QUSB2 support for ipq5210

This commit adds a new compatible string for the IPQ5210 SoC to the QUSB2
PHY driver. It maps the new compatible string to the existing
ipq6018_phy_cfg data structure.

> Add the phy init sequence for the Super Speed ports found
> on ipq5210.

Does this commit message accurately describe the patch contents?

The QUSB2 PHY driver is responsible for USB 2.0 ports, rather than Super
Speed ports. Additionally, the patch maps the compatible string to the
existing ipq6018_phy_cfg data instead of adding a new initialization
sequence.

Could the commit message be updated to reflect that it adds USB 2.0 PHY
support?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-usb2phy-v1-0-5f8338d466bf@oss.qualcomm.com?part=5