From: sashiko-bot@kernel.org
To: "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Subject: Re: [PATCH v2 2/4] media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115
Date: Fri, 15 May 2026 12:25:13 +0000 [thread overview]
Message-ID: <20260515122514.67724C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260515-iris-sm6115-v2-2-2ab75229de61@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The sequence under `items:` is incorrectly indented, which will cause a `dt_binding_check` failure due to `yamllint` strict indentation rules.
--
commit 43193b8fcb4051c6ff00308477a91cbef91be80b
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115
This commit adds a new compatible string for the Venus core on the Qualcomm
SM6115 platform, using QCM2290 as a fallback.
> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
> @@ -18,7 +18,11 @@ allOf:
>
> properties:
> compatible:
> - const: qcom,qcm2290-venus
> + oneOf:
> + - items:
> + - const: qcom,sm6115-venus
> + - const: qcom,qcm2290-venus
Will this pass the yamllint checks during make dt_binding_check?
The sequence under the items: key appears to be incorrectly indented.
The file Documentation/devicetree/bindings/.yamllint configures yamllint with
indent-sequences: true. This configuration requires the sequence indicators (-)
to be indented further than the parent items: key.
> + - const: qcom,qcm2290-venus
>
> power-domains:
> maxItems: 3
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-iris-sm6115-v2-0-2ab75229de61@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-05-15 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 11:59 [PATCH v2 0/4] media: iris: bring up driver on SM6115-based platforms Dmitry Baryshkov
2026-05-15 11:59 ` [PATCH v2 1/4] clk: qcom: gcc-sm6115: Set HW_CTRL_TRIGGER for video GDSC Dmitry Baryshkov
2026-05-15 12:12 ` Konrad Dybcio
2026-05-15 11:59 ` [PATCH v2 2/4] media: dt-bindings: qcom,qcm2290-venus: add Venus on SM6115 Dmitry Baryshkov
2026-05-15 12:25 ` sashiko-bot [this message]
2026-05-15 11:59 ` [PATCH v2 3/4] arm64: dts: qcom: sm6115: add venus device Dmitry Baryshkov
2026-05-15 11:59 ` [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable " Dmitry Baryshkov
2026-05-15 12:18 ` Konrad Dybcio
2026-05-15 12:57 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515122514.67724C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox