From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3129E2DB7B9 for ; Fri, 15 May 2026 12:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778849866; cv=none; b=cARRQPNHarjdnws4fSKspZiI1LO81AfLkH0f24CsoVJfviGWzxcoFYpMM8Bn9CLNTyDd4f4QjIt7IGLT1npW1barfAwjeVb32DMwEJJGhgi5NgPbiOcoQzV5pGhcTx/B16heuSe9jk1/4OaLaqP49TJ5r1ym8q3VwPYGLWOAdoU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778849866; c=relaxed/simple; bh=yxfuK9gQx1WbbllwbVouyZJWpOPie+fm3+30lLExS6c=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=kdaa8v2AgyIp9vuJdRwVYUHCIovTKIcvMarHIq0TozGyrfGATDt01fXWdbsRl9PIZOu2+97SRtVy1tXf/daWtFuEYsM2/vdCGe3rP0QWgnTwtHkT07CZyXBRQlmr9xOY1lpCG9DqG+am2A3z8BHGWkP7aMknQX5DO4UKoKq7xhI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bcxfs374; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bcxfs374" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC843C2BCB0; Fri, 15 May 2026 12:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778849865; bh=yxfuK9gQx1WbbllwbVouyZJWpOPie+fm3+30lLExS6c=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=Bcxfs3741uJx5ZVj09+S/FjtsYzDplE5z1Um66rX3nU3rA6jHfc0fRli48oad5UtN HDFEK3nj9KZEYf939KTqZ4FLzVCFXcu6qGzSgQTKgBK+ZpOjA7i1Tn72glCu6L21YQ euGZVxSZOQGy9fJRKbxWAP2/Lc45Vq/1EwP9FI72v9tIVGc/hb+5XuZ1qrH6qnNkKq f1w2HEK8NtXPERmd8cSklV9/ueJY0tV7viWevEDvk+7swSc68bBrrJCCdV06mwQSjZ DtFHn8ZwU6r2Nk9++OWoEcLpR9bPQVXS+vPYvCMfTpmBF5rYe6C1an1XsEqOcHcrYv n82lfJ3YV4K6w== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: qrb4210-rb2: enable venus device Reply-To: sashiko-reviews@lists.linux.dev To: "Dmitry Baryshkov" Cc: conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260515-iris-sm6115-v2-4-2ab75229de61@oss.qualcomm.com> References: <20260515-iris-sm6115-v2-4-2ab75229de61@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 15 May 2026 12:57:45 +0000 Message-Id: <20260515125745.AC843C2BCB0@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The device tree override `firmware-name` has no functional effec= t, making the intended workaround a no-op. -- commit 52a51e0f4e822b65926de689abb3bd0218261df9 Author: Dmitry Baryshkov arm64: dts: qcom: qrb4210-rb2: enable venus device Enable the Venus en/decoding device on the Qualcomm RB2 board. The HFI Gen2 firmware for AR50Lt platforms doesn't work on RB2, so fix the firmware in the DT for now. > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/d= ts/qcom/qrb4210-rb2.dts > index 1203172729faa..a6236b09cdbd9 100644 > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts > @@ -739,6 +739,12 @@ &usb_qmpphy_out { > remote-endpoint =3D <&pmi632_ss_in>; > }; > =20 > +&venus { > + firmware-name =3D "qcom/venus-6.0/venus.mbn"; Does this firmware-name property actually change the driver behavior? Looking at qcm2290_res in drivers/media/platform/qcom/venus/core.c (which handles the qcom,qcm2290-venus fallback compatible used by this platform), the default fwname is also qcom/venus-6.0/venus.mbn. In drivers/media/platform/qcom/venus/firmware.c, if the firmware-name prope= rty is absent, the driver falls back to core->res->fwname. Since the string provided here exactly matches the default fallback, the override appears to have no functional effect. Was a different firmware name intended to avoid the broken HFI Gen2 firmwar= e? > + > + status =3D "okay"; > +}; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260515-iris-sm611= 5-v2-0-2ab75229de61@oss.qualcomm.com?part=3D4