Re: [PATCH V7 05/11] iio: imu: inv_icm42607: Add PM support for icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unconditional assignment of runtime PM callbacks using RUNTIME_PM_OPS causes dead code when CONFIG_PM is disabled.
--

commit 2b859f6a3a3693a6dff734a7ea031d9f3a2a527f
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add PM support for icm42607

Add power management support for the ICM42607 device driver.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> index 1088c5c7076f8..e27ad0319a125 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c

[ ... ]

> +static int inv_icm42607_runtime_resume(struct device *dev)
> +{
> +	struct inv_icm42607_state *st = dev_get_drvdata(dev);
> +
> +	guard(mutex)(&st->lock);
> +
> +	return inv_icm42607_enable_vddio_reg(st);
> +}
> +
> +EXPORT_NS_GPL_DEV_PM_OPS(inv_icm42607_pm_ops, IIO_ICM42607) = {
> +	SYSTEM_SLEEP_PM_OPS(inv_icm42607_suspend, inv_icm42607_resume)
> +	RUNTIME_PM_OPS(inv_icm42607_runtime_suspend,
> +		       inv_icm42607_runtime_resume, NULL)

Will this result in dead code if CONFIG_PM is disabled?

Unlike SYSTEM_SLEEP_PM_OPS which internally wraps its arguments with
pm_sleep_ptr(), RUNTIME_PM_OPS does not use pm_ptr() for its callbacks.
This leaves the static inv_icm42607_runtime_suspend and
inv_icm42607_runtime_resume functions compiled even when PM is disabled.

Could this be updated to use pm_ptr() for the runtime PM callbacks, or
alternatively use the DEFINE_RUNTIME_DEV_PM_OPS macro?

> +};
> +
>  MODULE_AUTHOR("InvenSense, Inc.");

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515130018.237378-1-macroalpha82@gmail.com?part=5