Re: [PATCH 1/1] dt-bindings: trivial-devices: add fsl,mc1323

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Miscategorization of the fsl,mc1323 complex network transceiver as a trivial device.
--

commit 21d3bd06bf5d8d09338547376852b755873e842b
Author: Frank Li <Frank.Li@nxp.com>
dt-bindings: trivial-devices: add fsl,mc1323

This commit adds support for the Freescale 2.4 GHz IEEE 802.15.4/ZigBee
mc1323 by listing it as a compatible string in the trivial-devices schema.

> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 23fd4513933a4..28b059c858dd1 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
[ ... ]
> @@ -127,6 +127,8 @@ properties:
>            - domintech,dmard09
>              # DMARD10: 3-axis Accelerometer
>            - domintech,dmard10
> +            # Freescale 2.4 GHz IEEE® 802.15.4/ZigBee
> +          - fsl,mc1323

The trivial-devices.yaml binding is intended for simple SPI/I2C devices and
strictly enforces additionalProperties: false. Since the Freescale MC1323 is
a complex System-on-Chip that includes an MCU and a transceiver, wouldn't it
require additional properties like reset lines, regulators, clocks, or MAC
address configurations?

Adding it here might restrict the binding and cause future schema validation
failures when someone attempts to properly define those necessary hardware
properties.

Should this device have a dedicated binding schema instead of being
categorized as a trivial device?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515163959.1948799-1-Frank.Li@oss.nxp.com?part=1