Re: [PATCH v2 3/4] arm64: dts: qcom: Add HONOR MagicBook Art 14 device tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The PMIC GLINK `usb-c-connector` nodes (`connector@0` and `connector@1`) lack `port@2` definitions for SBU (Sideband Use) routing, and there are no SBU mux nodes defined in the device tree.
- [Medium] The sound card `model` property is set to `"X1E80100-CRD"` instead of a unique board-specific name.
--

commit 8c00a576dbb39e5e379a22f05075db6f00396289
Author: Konstantin Shabanov <mail@etehtsea.me>

arm64: dts: qcom: Add HONOR MagicBook Art 14 device tree

This commit introduces support for the HONOR MagicBook Art 14 laptop,
including features such as sound, Bluetooth, DP over USB-C, and more.

Link: https://lore.kernel.org/all/871px910m1.wl-kirill@korins.ky/
Link: https://github.com/vamanea/linux-magicbook/blob/x1e80100-magicbook-6.19/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts
Link: https://github.com/alsa-project/alsa-ucm-conf/pull/755

> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts b/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts
> new file mode 100644
> index 0000000000000..803f2614ce46a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-honor-magicbook-art-14.dts

[ ... ]

> +	pmic-glink {
> +		compatible = "qcom,x1e80100-pmic-glink",
> +			     "qcom,sm8550-pmic-glink",
> +			     "qcom,pmic-glink";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
> +				    <&tlmm 123 GPIO_ACTIVE_HIGH>;
> +
> +		/* Left-side port, closer to the screen */
> +		connector@0 {
> +			compatible = "usb-c-connector";
> +			reg = <0>;
> +			power-role = "dual";
> +			data-role = "dual";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +
> +					pmic_glink_ss0_hs_in: endpoint {
> +						remote-endpoint = <&usb_1_ss0_dwc3_hs>;
> +					};
> +				};
> +
> +				port@1 {
> +					reg = <1>;
> +
> +					pmic_glink_ss0_ss_in: endpoint {
> +						remote-endpoint = <&usb_1_ss0_qmpphy_out>;
> +					};
> +				};
> +			};
> +		};

The commit message claims support for DP over USB-C, but the usb-c-connector
nodes (both connector@0 and connector@1) appear to lack port@2 definitions
for SBU (Sideband Use) routing, and there are no SBU mux nodes defined in
the device tree.

Since DisplayPort Alternate Mode requires Type-C SBU pins to carry the
DisplayPort AUX channel for EDID reading and link training, will DP over
USB-C function correctly here?

Without port@2 and the SBU mux/retimer nodes, it seems the OS won't be able
to control SBU routing or handle orientation switches.

[ ... ]

> +	sound {
> +		compatible = "qcom,x1e80100-sndcard";
> +		model = "X1E80100-CRD";
> +		audio-routing = "WooferLeft IN", "WSA WSA_SPK1 OUT",
> +				"TweeterLeft IN", "WSA WSA_SPK2 OUT",

The model name is set to "X1E80100-CRD", which typically belongs to the
Qualcomm Reference Design.

Since userspace ALSA UCM configurations rely on a unique, board-specific
model name to apply the correct audio routing and mixer settings, will
reusing the CRD name cause userspace to load an incorrect audio profile for
this laptop?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515172926.16597-1-mail@etehtsea.me?part=3