From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, Frank.Li@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH 1/1] dt-bindings: display: simple: add avic,tm097tdh02 panel
Date: Fri, 15 May 2026 20:13:54 +0000 [thread overview]
Message-ID: <20260515201355.1E168C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260515195935.2415466-1-Frank.Li@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit adds the `avic,tm097tdh02` compatible string to the device tree bindings schema but fails to add the corresponding driver match data in the `panel-simple` driver, while the schema incorrectly rejects fallback strings.
- [Low] Typo in the commit message: 'compatilbe'.
--
commit 6c3fff393da11c29533acb6535efaaa08a1b9910
Author: Frank Li <Frank.Li@nxp.com>
dt-bindings: display: simple: add avic,tm097tdh02 panel
This commit adds the compatible string for the AVIC Optoelectronics 9.7"
panel to the simple panel device tree bindings schema.
> dt-bindings: display: simple: add avic,tm097tdh02 panel
>
> Add compatilbe string avic,tm097tdh02 for AVIC Optoelectronics 9.7".
This isn't a bug, but there is a typo (compatilbe) in the commit message.
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 3e41ed0ef5d51..80e7c6420b289 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -63,6 +63,8 @@ properties:
> - auo,p320hvn03
> # Shanghai AVIC Optoelectronics 7" 1024x600 color TFT-LCD panel
> - avic,tm070ddh03
> + # Shanghai AVIC Optoelectronics 9.7" 1024x600 color TFT-LCD panel
> + - avic,tm097tdh02
Does this new compatible string also need to be added to the match table in
the panel-simple.c driver?
The panel-simple.yaml schema restricts the compatible property to a single
string since it is added under an enum. If a device tree uses only the
avic,tm097tdh02 string to pass schema validation, the driver will silently
fail to probe at runtime because the string is missing from the driver's
match table.
Conversely, if a device tree relies on a fallback string to ensure the driver
probes successfully, the schema validation will fail because it does not
currently accept an array of strings for this panel.
Should the schema be updated to allow a fallback string, or should the driver
be updated to match this standalone string directly?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515195935.2415466-1-Frank.Li@oss.nxp.com?part=1
prev parent reply other threads:[~2026-05-15 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 19:59 [PATCH 1/1] dt-bindings: display: simple: add avic,tm097tdh02 panel Frank.Li
2026-05-15 20:13 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515201355.1E168C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox