Re: [PATCH 3/4] riscv: dts: spacemit: enable eMMC on Milk-V Jupiter

[Yixun Lan <dlan@kernel.org>]

Hi Aurelien,

On 09:48 Fri 15 May     , Aurelien Jarno wrote:
> On 2026-05-14 23:49, E Shattow wrote:
> > On 5/14/26 08:56, Aurelien Jarno wrote:
> > > The Milk-V Jupiter board has a connector for an eMMC module. Add an
> > > entry for it in the device tree and alias it mmc0. As it is not
> > > populated by default, do no mark it as non-removable.
> > > 
> > 
> > The meaning of "non-removable" here is whether it is expected to be
> > added and removed during use, requiring to be probed again; not whether
> > it is a user configurable module or soldered down part.
> 
> Not connecting the eMMC module and larking it as non-removable causes this info
> message to appears in the logs:
> 
> mmc0: SDHCI controller on d4281000.mmc [d4281000.mmc] using ADMA
> mmc0: Failed to initialize a non-removable card
> 

I'm with E Shattow here, and would prefer to add "non-removable" property,
Unlike SD card, the eMMC has no CD pin, some logic may be handled slightly
differently.

For that failure message, I have no idea how to deal with it but might
just ignore it.. Guess it's the price that have to pay if enabling the
eMMC in DT but has no module soldered or plugged in?

-- 
Yixun Lan (dlan)