From: Yixun Lan <dlan@kernel.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: alex@ghiti.fr, aou@eecs.berkeley.edu, conor+dt@kernel.org,
devicetree@vger.kernel.org, krzk+dt@kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
palmer@dabbelt.com, pjw@kernel.org, robh@kernel.org,
spacemit@lists.linux.dev
Subject: Re: [PATCH v3 1/2] riscv: dts: spacemit: add fixed regulators for OrangePi R2S
Date: Sat, 16 May 2026 13:46:02 +0000 [thread overview]
Message-ID: <20260516134602-GKA3679294@kernel.org> (raw)
In-Reply-To: <20260513060030.616473-1-amadeus@jmu.edu.cn>
Hi Chukun,
On 14:00 Wed 13 May , Chukun Pan wrote:
> Hi,
>
> > please check my comment below, I think this patch has similar issue
> >
> > https://lore.kernel.org/all/20260511065338-GKA3624147@kernel.org/
>
> I don't think this is an issue. Otherwise, these commits need to be fixed:
> https://github.com/torvalds/linux/commit/1df07a40453fd652132051419140950d47941fe9
> https://github.com/torvalds/linux/commit/ae9d03f8aec76c1bff21083b67c211238d7c57b1
>
I agree, these patch was introduced before we learned the convention from
DT maintainer, got no comment in that review phase, so it just slip in
so yes, we should fix it, and patches are welcome..
> Let's confirm the current DT preferred:
>
> - regulator-fixed
>
> nodename: Preferred name is 'regulator-[0-9]v[0-9]'
>
> gpio/gpios: Preferred 'gpios'
> https://github.com/torvalds/linux/commit/12df2c182ccb850988d2680a422211a812fb5cb2
>
> There is no specification or preference stating that regulators without
> software or GPIO control should be removed.
Not exactly, if some device driver explicitly request regulator, then
fixed regulators without software or GPIO control are still needed
Please refer to this reply from Krzysztof, fixed, non-controllable regulator isn't
really necessary if no driver/device used, will only waste memory, slow down boot time..
https://lore.kernel.org/all/90eafe45-7863-4c1d-b1e5-55a4fe32c806@kernel.org/
In this patch, I think both vcc_5v0 and vcc4v0 can be removed
>
> This has been discussed many times, and people are used to describing DT
> according to the schematic:
> https://lore.kernel.org/all/44ba02e34d7bf6a6657894802a87b690@manjaro.org/
>
For Dragan Simic's reply, I see no ACK from DT maintainer
> Therefore, if you consider these regulators unacceptable, we should remove
> them from other dts in spacemit, or allow such changes.
>
I would prefer to remove it, see comments above
> Thanks,
> Chukun
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2026-05-16 13:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 10:00 [PATCH v3 0/3] riscv: dts: spacemit: enable USB3 on OrangePi Chukun Pan
2026-04-10 10:00 ` [PATCH v3 1/2] riscv: dts: spacemit: add fixed regulators for OrangePi R2S Chukun Pan
2026-05-11 7:07 ` Yixun Lan
2026-05-13 6:00 ` Chukun Pan
2026-05-16 13:46 ` Yixun Lan [this message]
2026-04-10 10:00 ` [PATCH v3 2/2] riscv: dts: spacemit: enable USB3 on " Chukun Pan
2026-04-30 10:18 ` [PATCH v3 0/3] riscv: dts: spacemit: enable USB3 on OrangePi Chukun Pan
2026-05-11 6:01 ` Chukun Pan
2026-05-11 7:05 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516134602-GKA3679294@kernel.org \
--to=dlan@kernel.org \
--cc=alex@ghiti.fr \
--cc=amadeus@jmu.edu.cn \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox