From: sashiko-bot@kernel.org
To: "Jai Luthra" <jai.luthra@ideasonboard.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: media: i2c: Add Sony IMX678
Date: Sat, 16 May 2026 14:28:26 +0000 [thread overview]
Message-ID: <20260516142827.4E794C19425@smtp.kernel.org> (raw)
In-Reply-To: <20260516-imx678-v2-1-4854ac61d6fb@ideasonboard.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The binding defines `xclr-gpios` instead of the standard `reset-gpios` property.
--
commit 509a0ec53ea479ccac82b92f2f55a9650f4691ac
Author: Jai Luthra <jai.luthra@ideasonboard.com>
dt-bindings: media: i2c: Add Sony IMX678
Sony IMX678 is an 8.4 Megapixel CMOS sensor that outputs pixels over MIPI
CSI-2 bus. This commit adds device tree bindings for it.
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
> new file mode 100644
> index 0000000000000..8f12853f40e62
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx678.yaml
[ ... ]
> + dvdd-supply:
> + description: Digital power supply (1.2V)
> +
> + xclr-gpios:
> + description: Sensor XCLR GPIO
> + maxItems: 1
Should this use the standard reset-gpios property instead of the datasheet
pin name xclr-gpios?
Device tree bindings typically use reset-gpios to describe reset lines for
consistency across media sensors, rather than hardware-specific pin names.
[ ... ]
> + avdd-supply = <&camera_avdd_3v3>;
> + ovdd-supply = <&camera_ovdd_1v8>;
> + dvdd-supply = <&camera_dvdd_1v2>;
> +
> + xclr-gpios = <&gpio 0 GPIO_ACTIVE_HIGH>;
Similarly, does the example need to be updated to reflect reset-gpios if
the property name is changed above?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260516-imx678-v2-0-4854ac61d6fb@ideasonboard.com?part=1
next prev parent reply other threads:[~2026-05-16 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 14:19 [PATCH v2 0/2] media: Add bindings and driver for Sony IMX678 Jai Luthra
2026-05-16 14:19 ` [PATCH v2 1/2] dt-bindings: media: i2c: Add " Jai Luthra
2026-05-16 14:28 ` sashiko-bot [this message]
2026-05-16 14:19 ` [PATCH v2 2/2] media: i2c: imx678: Add driver for " Jai Luthra
2026-05-16 15:05 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516142827.4E794C19425@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jai.luthra@ideasonboard.com \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox