Re: [PATCH v3 1/4] dt-bindings: timer: econet: Update EN751627 for multi-IRQ

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] DT Binding Example Validation Failure
--

commit 2aadbe8d15e40c585e5998e7532f23b02294a2a3
Author: Caleb James DeLisle <cjd@cjdns.fr>

dt-bindings: timer: econet: Update EN751627 for multi-IRQ

This commit updates the EN751627 timer binding to describe its use of an
individual IRQ per timer (4 total) compared to the single percpu IRQ used
by the EN751221 family. The constraints and example are updated accordingly.

> diff --git a/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml b/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml
> index c1e7c2b6afde1..16f32741473fe 100644
> --- a/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml
> +++ b/Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml

[ ... ]

> @@ -52,21 +53,31 @@ allOf:

[ ... ]

>  examples:
>    - |
> +    #include <dt-bindings/interrupt-controller/mips-gic.h>
>      timer@1fbf0400 {
> -        compatible = "econet,en751627-timer", "econet,en751221-timer";
> +        compatible = "econet,en751627-timer";

Does this updated example fail dt_binding_check validation?

The example changes the compatible property to a single string, removing the
fallback to "econet,en751221-timer". This correctly reflects that the two
hardware variants have incompatible interrupt topologies.

However, it appears the properties definition for compatible in this schema
was not updated. If the schema still requires "econet,en751627-timer" to be
part of an array with the "econet,en751221-timer" fallback, this single
string example will not match the expected array schema.

Should the compatible schema definition be updated to allow
"econet,en751627-timer" as a standalone string?

>          reg = <0x1fbf0400 0x100>, <0x1fbe0000 0x100>;
>          interrupt-parent = <&intc>;
> -        interrupts = <30>;
> +        interrupts = <GIC_SHARED 30 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SHARED 29 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SHARED 37 IRQ_TYPE_LEVEL_HIGH>,
> +                     <GIC_SHARED 36 IRQ_TYPE_LEVEL_HIGH>;
>          clocks = <&hpt_clock>;
>      };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516182648.3987792-1-cjd@cjdns.fr?part=1