From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CBC82C3271; Sun, 17 May 2026 20:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779051122; cv=none; b=PA/94BpXi0azafOsK7zBy1Rolgk8TKv7kGTsauXqod2O7g+AoWfISKSfK+ySKFBnuK4mr5/Q3vOA4UhqqaNZK9EWlmpHHgbXO7DY0ZolettvUlEyOKvP7W4NG7YlheQJFK1qDeys5ojF7OK/7sCA4LU8LmY7EAkXF0wGrkxQUns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779051122; c=relaxed/simple; bh=Og4fBV0EtD0xhgQyzKrvnJkkN7/Nmm1sRZwXKkR+uWU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pNleYad3e84E/QCUgde+Ae5kvDVZCHymbKwZsjiO2UBbBOlZSFOARNAc0V+BJUbX30R0H8NsnDI5dzCddIs8LKOoKzOINk8fvT/Ixpt7B/VgdPfgteBHlsVjTE5FtszRMak08CfsCoQirk1ZCjZ/+yj31btaFdfLSTVXZ1+leEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E1jaTnUp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E1jaTnUp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF625C2BCB0; Sun, 17 May 2026 20:51:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779051121; bh=Og4fBV0EtD0xhgQyzKrvnJkkN7/Nmm1sRZwXKkR+uWU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E1jaTnUpR8hVplCRXocLMST2NUTRStFSqyNR/r0AdCRcRKkgG7wbT2QSTzUGIAaZU 5erC8I20OCJEccLXKAm/EeTDPZTW+fAQv7zkZWKf0leDMThsIy2qGBrke9sqc9l3yy VbVGJKs/Nv1YHZiBb6BdrvyHpl63iwpPKc8b+U3AEochNJEN+gwlA/oJZC73FCtKY7 xylPAAnVYcqiWg54xErmoNXLWPRP/VzscTYciqzPt0mFQS4WGRS2RzpmPOgLkoUljr hJ6T4V+YzxQnCEvO/rkJs+eG72lYTW7o6AbjuVerwvAyfBsHrxiuQyQ6srB0K+gsXD 0fAp99LjNRDNA== Date: Sun, 17 May 2026 21:51:56 +0100 From: Conor Dooley To: Chuanhong Guo Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] dt-bindings: clock: add binding header for sf21-topcrm Message-ID: <20260517-pulsate-shining-547432ab2ca0@spud> References: <20260517-sf21-topcrm-v1-0-438f2e0513ff@gmail.com> <20260517-sf21-topcrm-v1-2-438f2e0513ff@gmail.com> <20260517-cartoon-slather-ec5ad7605449@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XBSltlWXNSQe/OJJ" Content-Disposition: inline In-Reply-To: <20260517-cartoon-slather-ec5ad7605449@spud> --XBSltlWXNSQe/OJJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, May 17, 2026 at 09:47:26PM +0100, Conor Dooley wrote: > On Sun, May 17, 2026 at 10:12:56PM +0800, Chuanhong Guo wrote: > > +#define SF21_CLK_PCIE_REFP 30 > > +#define SF21_CLK_MAX 31 >=20 > > +#define SF21_RESET_IROM 17 > > +#define SF21_RESET_MAX 18 >=20 >=20 > Having _MAX is not permitted, but is also really confusing that "max" > appears to be max+1, so actually represents the count not the max? To be clear, if you need a define like this, put it in the driver. Bindings having a "_MAX" or "NUM_CLKS" doesn't make sense, and half the time this number ends up changing anyway. Also, squash this with the patch adding the clock binding. Cheers, Conor. --XBSltlWXNSQe/OJJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCagoqbAAKCRB4tDGHoIJi 0kXQAP9LJgmoesY0Ipn5SDkHI1favq4yEm6Jb5EycZjpUwTLtAEAsN4MhlOWEdtS 0trUPoitDOYu794uOuGQPIOzV0sDKQE= =ZyXF -----END PGP SIGNATURE----- --XBSltlWXNSQe/OJJ--