Re: [PATCH v1 3/6] mfd: lm3533: Add support for VIN power supply

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Implicit dependency on <linux/regulator/consumer.h> without an explicit include.
--

commit a9ff3766520433ef45982257dcd46aa034405482
Author: Svyatoslav Ryhel <clamor95@gmail.com>

mfd: lm3533: Add support for VIN power supply

Add support for 2.7V-5.5V VIN power supply.

> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 83ebd780f39d5..131eb1a1c8eba 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
[ ... ]
> @@ -173,14 +173,25 @@ static int lm3533_set_lvled_config(struct lm3533 *lm3533, u8 lvled, u8 led)
>  	return ret;
>  }
>  
> -static void lm3533_enable(struct lm3533 *lm3533)
> +static int lm3533_enable(struct lm3533 *lm3533)
>  {
> +	int ret;
> +
> +	ret = regulator_enable(lm3533->vin_supply);

This isn't a bug, but should we include <linux/regulator/consumer.h> in this
file? Relying on implicit includes can lead to build breakages if upstream
headers are reorganized.

> +	if (ret) {
> +		dev_err(lm3533->dev, "failed to enable vin power supply\n");
> +		return ret;
> +	}
> +
>  	gpiod_set_value(lm3533->hwen, 1);
> +
> +	return 0;
>  }
[ ... ]
> diff --git a/include/linux/mfd/lm3533.h b/include/linux/mfd/lm3533.h
> index 3aa962d4c7473..e355a3ac982ec 100644
> --- a/include/linux/mfd/lm3533.h
> +++ b/include/linux/mfd/lm3533.h
> @@ -28,6 +28,7 @@ struct lm3533 {
>  	struct regmap *regmap;
>  
>  	struct gpio_desc *hwen;
> +	struct regulator *vin_supply;

Could this header use a forward declaration for struct regulator?

>  
>  	u32 boost_ovp;
>  	u32 boost_freq;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260517074306.30937-1-clamor95@gmail.com?part=3