From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C1222F8EBC; Sun, 17 May 2026 14:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779028508; cv=none; b=Q+sBnek7vq09Yl7yDEYRce8yGqpaQEXoW+YaTIUCzCaaLZeFQSYcUHY/DwtU5hpXjKzGl4l8c2l1Maa/76zPWiRiQS73jptJsh0N612q9VNaQut9IabCHp7e8Jqn52GjLSSCcLHsmdLkL6Be4rpwZ8cRGVFNlW3FhjylMXVZS54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779028508; c=relaxed/simple; bh=7DDFiqGdr88lpnr9v5VOxAr5PZ6BDStRMX/RHYyBXqU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pnZlRZInMcKe1a73EYMy/duDBNQwrch/Q9IFhP5+yv1bfIHt2JimYLAuHuF1GwkXYSJIrPInIdPny6Cf3HxOsD2NNTz+nVqX71GXMaHUpRXU17Ql/CZ+NPUaHdO4Z+1CIXhMMKS/UIlopKgT0bMaZvTV7P3sbr2gstde2foC2eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XecxlReB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XecxlReB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2962C2BCB0; Sun, 17 May 2026 14:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779028507; bh=7DDFiqGdr88lpnr9v5VOxAr5PZ6BDStRMX/RHYyBXqU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XecxlReB7c2xtiFZhFxrNm4ZOnpL5RFVhoRc1LlDu7/2YECnO0DNPqrMQwRJYJUaw oHXSsGPBo5LteH3TqvSEW5ws4GbvlUrMzYlmfKkjPzwO2XwRJwUAtbAea+ywsEDm0r jwErQvlK2CMy9piFvX6CcwH2lsqp5koEoxfYoPITSGoJok1H2RoVlOQuHI+ebacqVh Eur2h/1KXNk2lMCOG/WhiM77EoZi4W/RmkX3tked9G4C7NbMNvySoO9hjqolGpV6uj cVB2ouxmaXc3bAN0yt5n1Xdnw4v0zgwRRi7Mkvj4J8mVkWUDh0dk/EmwwkbSjfOLnv J2FdCZaPLvd0g== Date: Sun, 17 May 2026 15:34:58 +0100 From: Jonathan Cameron To: Taha Ed-Dafili <0rayn.dev@gmail.com> Cc: lars@metafoo.de, Michael.Hennerich@analog.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, skhan@linuxfoundation.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/5] iio: dac: ad5504: Align headers with IWYU principle Message-ID: <20260517153458.47838fa6@jic23-huawei> In-Reply-To: <20260509142047.30302-4-0rayn.dev@gmail.com> References: <20260509142047.30302-1-0rayn.dev@gmail.com> <20260509142047.30302-4-0rayn.dev@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 9 May 2026 15:20:41 +0100 Taha Ed-Dafili <0rayn.dev@gmail.com> wrote: > Update the header inclusions to follow the IWYU principle and ensure > they are sorted alphabetically: > > - Remove , , and as they > are unused. The driver relies on devm_ managed allocations, so slab > is not required. > - Replace with as only the BIT() and > GENMASK() macros are used. > - Add for struct spi_device_id. > - Add and for error codes and data types. > - Add for cpu_to_be16(). > - Add for ARRAY_SIZE(). > - Add for string to integer conversions. > > Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> > --- > drivers/iio/dac/ad5504.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c > index 03ce37e2c616..57e6eeed26ef 100644 > --- a/drivers/iio/dac/ad5504.c > +++ b/drivers/iio/dac/ad5504.c > @@ -5,16 +5,19 @@ > * Copyright 2011 Analog Devices Inc. > */ > > -#include > +#include asm always go after linux in their own block. Normally after the linux/iio block. > +#include > +#include > #include This is like kernel.h in that if we are tidying up headers we should be looking to include dev_printk.h etc rather than this. I couldn't immediately see a reason we need this in the driver. If there is one it is fine to keep it. Otherwise this lot seems reasonable. > -#include > +#include > #include > -#include > +#include > +#include > #include > #include > -#include > #include > #include > +#include > > #include > #include