From: sashiko-bot@kernel.org
To: "Marek Vasut" <marek.vasut+renesas@mailbox.org>
Cc: wsa+renesas@sang-engineering.com, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: r8a78000: Describe all reserved memory
Date: Sun, 17 May 2026 16:39:51 +0000 [thread overview]
Message-ID: <20260517163952.335D6C2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260517163212.18016-1-marek.vasut+renesas@mailbox.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The closing brace of the `reserved-memory` node is incorrectly indented with spaces instead of a tab.
--
commit d018e096715e5182300385286aab8a1caa68c6f1
Author: Marek Vasut <marek.vasut+renesas@mailbox.org>
arm64: dts: renesas: r8a78000: Describe all reserved memory
This commit updates the device tree to fully describe all available DRAM on
the r8a78000 platform. It adds a reserved-memory node to block off regions
used by firmware, IPL parameters, TFA BL31, and OPTEE-OS.
> diff --git a/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
> index a721734fbd5d0..99f4cfb53e0f8 100644
> --- a/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
[ ... ]
> @@ -65,6 +64,36 @@ memory@1e00000000 {
[ ... ]
> + /* TEE TZ DRAM. */
> + tee@8c400000 {
> + reg = <0x0 0x8c400000 0x0 0x02000000>;
> + no-map;
> + };
> + };
This isn't a bug, but does the closing brace of the reserved-memory node
use spaces instead of a tab for indentation?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260517163212.18016-1-marek.vasut+renesas@mailbox.org?part=1
next prev parent reply other threads:[~2026-05-17 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 16:31 [PATCH] arm64: dts: renesas: r8a78000: Describe all reserved memory Marek Vasut
2026-05-17 16:39 ` sashiko-bot [this message]
2026-05-18 7:18 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260517163952.335D6C2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox