Re: [PATCH v4 2/3] clk: qcom: camcc-glymur: Add camera clock controller driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] CLK_GLYMUR_CAMCC sets 'default m if ARCH_QCOM', but related configs for the same SoC (CLK_GLYMUR_DISPCC, CLK_GLYMUR_GCC) do not follow this pattern.
--

commit 22b429ddff7c202cf3781d6d957f45cbf3575c19
Author: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>

clk: qcom: camcc-glymur: Add camera clock controller driver

Add support for the camera clock controller for camera clients
to be able to request for camcc clocks on Glymur platform.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index df21ef5ffd686..754c3b823f3f8 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -45,6 +45,17 @@ config CLK_ELIZA_TCSRCC
>  	  Support for the TCSR clock controller on Eliza devices.
>  	  Say Y if you want to use peripheral devices such as USB/PCIe/UFS.
>  
> +config CLK_GLYMUR_CAMCC
> +	tristate "Glymur Camera Clock Controller"
> +	depends on ARM64 || COMPILE_TEST
> +	select CLK_GLYMUR_GCC
> +	default m if ARCH_QCOM

Is this default intentional? Looking at related configs for the same SoC family
like CLK_GLYMUR_DISPCC below, they do not appear to follow this pattern of
setting "default m if ARCH_QCOM".

> +	help
> +	  Support for the camera clock controller on Qualcomm Technologies, Inc
> +	  Glymur devices.
> +	  Say Y if you want to support camera devices and functionality such as
> +	  capturing pictures.
> +
>  config CLK_GLYMUR_DISPCC
>  	tristate "Glymur Display Clock Controller"
>  	depends on ARM64 || COMPILE_TEST

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260517-glymur_camcc-v4-0-9d00acffdbf7@oss.qualcomm.com?part=2