Re: [PATCH v5 05/13] dt-bindings: iio: frequency: add ad9910

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The `#clock-cells` property is missing from the `required` list and the `examples` section.
- [Low] The `interrupt-names` property lacks strict array item ordering.
- [Low] The `reset-gpios` property is missing a `maxItems: 1` constraint.
--

commit 873abe87012e16a8a1194f7d05ae22b3bea1a586
Author: Rodrigo Alencar <rodrigo.alencar@analog.com>

dt-bindings: iio: frequency: add ad9910

This commit adds device tree bindings for the Analog Devices AD9910 Direct
Digital Synthesizer. It includes properties for SPI, clocks, DAC current,
interrupts, and various GPIOs.

> diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,ad9910.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,ad9910.yaml
> new file mode 100644
> index 0000000000000..5ab0db62dbf1f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/frequency/adi,ad9910.yaml
[ ... ]
> +  interrupt-names:
> +    minItems: 1
> +    maxItems: 2
> +    items:
> +      enum: [ drover, ram_swp_ovr ]

Should this use a list of const items instead of an enum? An enum allows the
array elements to appear in any order or contain duplicates. Using a list
with const constraints such as items: [ { const: drover },
{ const: ram_swp_ovr } ] would enforce the strict hardware mapping.

[ ... ]
> +  reset-gpios:
> +    description:
> +      GPIOs controlling the Main Device reset.
> +
> +  io-reset-gpios:
> +    maxItems: 1

Does the reset-gpios property need a maxItems: 1 constraint? The description
mentions it controls the main device reset, but unlike the single-pin
io-reset-gpios property below it, it lacks this constraint.

[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - dvdd-io33-supply
> +  - avdd33-supply
> +  - dvdd18-supply
> +  - avdd18-supply

Since the device defines #clock-cells, should it be included in this
required list? Hardware with provider capabilities typically needs the
corresponding standard properties explicitly added to the required list.

[ ... ]
> +            adi,pll-enable;
> +            adi,charge-pump-current-microamp = <387>;
> +            adi,refclk-out-drive-strength = "disabled";
> +            output-range-microamp = <0 20070>;
> +        };
> +    };

Does the example node also need to include the #clock-cells property? To
ensure validation passes, the examples section generally needs to include
all required properties.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260517-ad9910-iio-driver-v5-0-31599c88314a@analog.com?part=5