Re: [PATCH v2 1/2] dt-bindings: Add bindings for StarFive JHB100 SoC trng controller

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2381 bytes --]

Sashiko devs,

On Mon, May 18, 2026 at 07:06:21AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Removing the existing 'starfive,jh8100-trng' compatible string breaks backwards compatibility.
> --
> 
> commit 847e83dc6a2024f6cb7a70fd0453035b2808bedb
> Author: Lianfeng Ouyang <lianfeng.ouyang@starfivetech.com>
> 
> dt-bindings: Add bindings for StarFive JHB100 SoC trng controller
> 
> This commit adds device tree bindings for the StarFive JHB100 SoC TRNG
> controller, updates the maintainer, and removes the JH8100 compatible
> string.
> 
> > diff --git a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> > index 4639247e9e510..d21769b7d54e6 100644
> > --- a/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> > +++ b/Documentation/devicetree/bindings/rng/starfive,jh7110-trng.yaml
> 
> [ ... ]
> 
> >  properties:
> >    compatible:
> > -    oneOf:
> > -      - items:
> > -          - const: starfive,jh8100-trng
> > -          - const: starfive,jh7110-trng
> > -      - const: starfive,jh7110-trng
> > +    enum:
> > +      - starfive,jh7110-trng
> > +      - starfive,jhb100-trng
> 
> Does removing the existing "starfive,jh8100-trng" compatible string break
> backwards compatibility?

The commit message is perfunctory but does attempt to explains this.
Since the bot reply fails to retain the commit message as quoted text,
it's annoying to go figure that out.

It's really annoying that this happens, especially when the LLM text
references the commit message. Can you please change the email response
settings to retain the commit messages?

Cheers,
Conor.

> 
> Device tree bindings represent a stable ABI, and removing the previously
> merged "starfive,jh8100-trng" string breaks dt-schema validation for any
> existing or downstream device trees that used it. Even if the hardware is
> no longer supported, the standard practice is to retain such strings,
> perhaps optionally adding "deprecated: true", rather than deleting them
> outright.
> 
> >  
> >    reg:
> >      maxItems: 1
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260518065243.20865-1-lianfeng.ouyang@starfivetech.com?part=1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]