Re: [PATCH v2 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Property name typo: schema defines `firmware-names` but example uses standard `firmware-name`.
--

commit 79af2c3efbc97d2f61f76b26b50c0f08ac0264e4
Author: Neo Chang <YLCHANG2@nuvoton.com>

ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60

This commit adds device tree bindings documentation for the Nuvoton NAU83G60
audio amplifier.

> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml
> new file mode 100644
> index 0000000000000..756b3e9c43215
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8360.yaml
[ ... ]
> +  firmware-names:
> +    minItems: 2
> +    maxItems: 2
> +    description:
> +      Assign firmware filenames for left and right DSP cores.
[ ... ]
> +        codec@1a {
> +            #sound-dai-cells = <0>;
> +            compatible = "nuvoton,nau8360";
> +            reg = <0x1a>;
> +            nuvoton,dsp-bypass;
> +            nuvoton,pbtl-enable;
> +            nuvoton,dac-cur-enable;
> +            firmware-name = "NAU83G60.kcs.bin.l" , "NAU83G60.kcs.bin.r";

Will this pass the dt_binding_check validation?

The schema defines firmware-names in the properties block, but the example
uses firmware-name.

Since unevaluatedProperties is set to false, this mismatch will cause a
validation error when checking the example, or silently pass validation on
actual device trees without enforcing the minItems and maxItems constraints.

> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518024704.118613-1-YLCHANG2@nuvoton.com?part=1