Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] docs: dt: maintainer: Add Devicetree and OF maintainer profile document
Date: Mon, 18 May 2026 09:27:18 +0000	[thread overview]
Message-ID: <20260518092718.B33B0C2BCB7@smtp.kernel.org> (raw)
In-Reply-To: <20260518091942.29822-2-krzysztof.kozlowski@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Typos in the new documentation file: 'Pachwork' instead of 'Patchwork' in the section header, and 'statutes' instead of 'statuses' in the text.
- [Low] Incorrect tag ordering in the MAINTAINERS file.
--

commit 51df2774f45c1a37759547f78fcc2881a87cc94a
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

docs: dt: maintainer: Add Devicetree and OF maintainer profile document

Document how Devicetree and Open Firmware maintainers handle their
subsystem, focusing on how bindings are reviewed, applied, and the heavy
reliance on Patchwork.

> diff --git a/Documentation/process/maintainer-devicetree.rst b/Documentation/process/maintainer-devicetree.rst
> new file mode 100644
> index 0000000000000..b983c5f1d851b
> --- /dev/null
> +++ b/Documentation/process/maintainer-devicetree.rst
[ ... ]
> +3. DTS and drivers:
> +   DT maintainers might provide comments, but review is generally not expected.
> +
> +Pachwork
> +~~~~~~~~

This isn't a bug, but there is a typo in the section header.

If Pachwork is changed to Patchwork, should the underline also be extended to
9 characters to avoid a Sphinx build warning for the title underline being
too short?

> +
> +Devicetree maintainers review patches using Patchwork, so the current status of
> +a patch can be checked there. For typical driver submissions, Patchwork
> +receives the entire patch set, but only a few patches are usually Devicetree
> +bindings that are reviewed by DT maintainers.
> +
> +Explanation of Patchwork statutes:

This isn't a bug, but should this be statuses instead of statutes?

> +
> + - **New**: Not yet processed by the automation toolset.
> + - **Needs ACK**: Waiting for review by DT maintainers.
[ ... ]
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2fb1c75afd163..c0ef1ee78ffcc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
[ ... ]
> @@ -19962,6 +19963,7 @@ M:	Conor Dooley <conor+dt@kernel.org>
>  L:	devicetree@vger.kernel.org
>  S:	Maintained
>  Q:	http://patchwork.kernel.org/project/devicetree/list/
> +P:	Documentation/process/maintainer-devicetree.rst
>  C:	irc://irc.libera.chat/devicetree

This isn't a bug, but is this the correct tag ordering?

The preferred order defined at the top of the MAINTAINERS file specifies that
the chat (C:) tag should precede the subsystem profile (P:) tag.

>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
>  F:	Documentation/devicetree/

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518091942.29822-2-krzysztof.kozlowski@oss.qualcomm.com?part=1

  reply	other threads:[~2026-05-18  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18  9:19 [PATCH] docs: dt: maintainer: Add Devicetree and OF maintainer profile document Krzysztof Kozlowski
2026-05-18  9:27 ` sashiko-bot [this message]
2026-05-18 10:19   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260518092718.B33B0C2BCB7@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox