Re: [PATCH 2/2] dt-bindings: usb: richtek,rt1711h: add missing 'port' property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `port` node in the device tree example is incorrectly nested inside the `connector` node instead of being at the top level of the `rt1711h@4e` node.
--

commit 18a1ecff9551deb9d653752f739ababa33eb01fd
Author: Akash Sukhavasi <akash.sukhavasi@gmail.com>

dt-bindings: usb: richtek,rt1711h: add missing 'port' property

This commit adds the missing top-level port property to the
richtek,rt1711h schema to describe the role-switch graph endpoint. It also
updates the example to include this new port configuration.

> diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> --- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
> +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml
[ ... ]
> @@ -107,6 +114,12 @@ examples:
>                };
>              };
>            };
> +
> +          port {
> +            endpoint {
> +              remote-endpoint = <&usb_role_switch>;
> +            };
> +          };
>          };
>        };
>      };

Is this port node indented correctly in the example?

It looks like the 10-space indentation places it inside the connector node
rather than as a top-level property of the rt1711h@4e node as intended by
the schema update.

Should it be aligned with fewer spaces to be a sibling of the connector node
instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518142901.1747-1-akash.sukhavasi@gmail.com?part=2