Re: [PATCH 03/15] arm64: dts: st: add CAN1 support on stm32mp25

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `m_can1` device tree node is missing the `resets` property.
--

commit 9a45deb755da217a14f0986f9795adff2ebdf1f4
Author: Dario Binacchi <dario.binacchi@amarulasolutions.com>

arm64: dts: st: add CAN1 support on stm32mp25

This commit adds device tree support for the CAN1 controller on the stm32mp25
platform. It configures the necessary memory regions, interrupts, clocks,
access controllers, and power domains for the bosch,m_can compatible node.

> diff --git a/arch/arm64/boot/dts/st/stm32mp253.dtsi b/arch/arm64/boot/dts/st/stm32mp253.dtsi
> index eeceb086252bf..d5871203ccb01 100644
> --- a/arch/arm64/boot/dts/st/stm32mp253.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp253.dtsi
> @@ -43,6 +43,21 @@ &optee {
>  };
>  
>  &rifsc {
> +	m_can1: can@402d0000 {
> +		compatible = "bosch,m_can";
> +		reg = <0x402d0000 0x400>, <0x40310000 0xd50>;
> +		reg-names = "m_can", "message_ram";
> +		interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "int0", "int1";
> +		clocks = <&rcc CK_BUS_FDCAN>, <&rcc CK_KER_FDCAN>;
> +		clock-names = "hclk", "cclk";
> +		bosch,mram-cfg = <0x0 0 0 32 0 0 2 2>;
> +		access-controllers = <&rifsc 56>;
> +		power-domains = <&CLUSTER_PD>;

Should this node include the resets property?

The STM32MP25 RCC bindings define a dedicated hardware reset line for the
FDCAN block. While the generic bosch,m_can driver can fall back to a
software reset when the resets property is omitted, the STM32MP architecture
relies on the hardware reset to guarantee a pristine state.

Could omitting the resets property prevent the driver from acquiring the
hardware reset line and lead to unpredictable initialization failures if
the hardware is left in a fault state after bootloader execution, kexec,
or a warm reboot?

> +		status = "disabled";
> +	};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518143150.3138712-1-dario.binacchi@amarulasolutions.com?part=3