Re: [PATCH V8 04/10] iio: imu: inv_icm42607: Add I2C and SPI For icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The driver unconditionally fails to probe if the `interrupt-names` property is missing from the devicetree.
--

commit f16907e397de069b83b61a52946a989d7853c245
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add I2C and SPI For icm42607
    
This commit adds I2C and SPI driver support for InvenSense ICM-42607
devices. It introduces the necessary Kconfig and Makefile entries to allow
building the new modules.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c
> new file mode 100644
> index 0000000000000..8631579a609a0
> --- /dev/null
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_i2c.c
[ ... ]
> +static int inv_icm42607_probe(struct i2c_client *client)
> +{
> +	const struct inv_icm42607_hw *hw;
> +	struct regmap *regmap;
> +
> +	hw = i2c_get_match_data(client);
> +	if (!hw)
> +		return dev_err_probe(&client->dev, -ENODEV,
> +				     "Failed to get i2c data\n");
> +
> +	regmap = devm_regmap_init_i2c(client, &inv_icm42607_regmap_config);
> +	if (IS_ERR(regmap))
> +		return dev_err_probe(&client->dev, PTR_ERR(regmap),
> +				     "Failed to register i2c regmap %ld\n",
> +				     PTR_ERR(regmap));
> +
> +	return inv_icm42607_core_probe(regmap, hw, inv_icm42607_i2c_bus_setup);
> +}

This isn't a bug in this patch specifically, but since this patch enables the
I2C and SPI probing, it exposes an issue introduced in the core driver patch.

If the interrupt-names property is missing from the devicetree, the probe
unconditionally fails because inv_icm42607_core_probe() does:

    irq = fwnode_irq_get_byname(dev_fwnode(dev), "INT1");
    if (irq < 0)
        return dev_err_probe(dev, irq, "Unable to get INT1 interrupt\n");

Since interrupt-names is not a required property in the devicetree bindings
for invensense,icm42600 (which covers icm42607), a valid devicetree might only
provide the interrupts property. In this case, fwnode_irq_get_byname() returns
-EINVAL, causing the probe to fail unconditionally and rendering the device
unusable.

Should the core driver instead use the pre-resolved client->irq or spi->irq,
or fallback to fwnode_irq_get(dev_fwnode(dev), 0) like other drivers in the
subsystem do?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518200526.458421-1-macroalpha82@gmail.com?part=4