Re: [PATCH v2] riscv: dts: spacemit: k3: Add pwm support

[Yixun Lan <dlan@kernel.org>]

Hi

On 12:06 Mon 18 May     , sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
> - [High] The driver ignores the `bus` clock, which will lead to a system hang when accessing registers.
> - [Medium] DT binding violation due to undocumented compatible string and property constraints.
> - [Low] Copy-paste errors in pinctrl sub-node names.
> --
> 
> commit 4d46fb2ab333b7a733df38e29f0f7c7d23523cee
> Author: Yixun Lan <dlan@kernel.org>
> 
> riscv: dts: spacemit: k3: Add pwm support
>     
> This patch populates all PWM device tree nodes for the SpacemiT K3 SoC. It
> also adds the corresponding pinctrl configurations to easily enable them.
> 
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> > index 23899d3f308a0..06abca6d08832 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> > +++ b/arch/riscv/boot/dts/spacemit/k3-pinctrl.dtsi
> [ ... ]
> > +	/omit-if-no-ref/
> > +	pwm1_1_cfg: pwm1-1-cfg {
..
> > +		pwm0-0-pins {

sorry, I overlooked this.. will fix it in next version

> > +			pinmux = <K3_PADCONF(43, 6)>;	/* pwm1 */
> > +
> > +			bias-pull-up = <0>;
> > +			drive-strength = <25>;
> > +		};
> > +	};
> 
> This isn't a bug, but it looks like there might be a copy-paste error here.
> Should this sub-node be named pwm1-1-pins instead of pwm0-0-pins? This
> pattern also appears in other blocks like pwm1_2_cfg and pwm6_1_cfg.
> 

-- 
Yixun Lan (dlan)