From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E8F237C913 for ; Tue, 19 May 2026 06:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171001; cv=none; b=mDagll/QLSoqym0Vm26eaJx+kDOWImCs0mzgstnFvo5fCs100POkVD0kGczAQLGyX79TFQEUuRKTdbB3FfRG685VadFmtkej0DCAx2DbVpu8deRScRwyr/8+18QA9L124b7O05Lh9hI/rEMwyMHpJX0u1Aw3bVg5VPhb2Vbsgjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779171001; c=relaxed/simple; bh=uCn9+Ea9EmyReZNVQnl290VyGe66Yfpuyhu1nfAFBZU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=m0/Mt9kSfhH0We+ZJLAhmf1fcWBCoO3d+j0Uu5JJINMebEOVeqcyhuVChs2DTU01pQkWMoyN843bfZY+yMQ9DE6hfyJqlB4KZ/zihgfarv6RD2oFf0osmcn8xcJgz03qk9KNKh2gByXwFyryt3UW1YolkClJlT7vQukIAWrJhmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tn0exEEc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tn0exEEc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD84FC2BCB3; Tue, 19 May 2026 06:09:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779171000; bh=uCn9+Ea9EmyReZNVQnl290VyGe66Yfpuyhu1nfAFBZU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=Tn0exEEc1EHAYQJEn/Kq/bQ4jsUZVXmJzfm4AltkzyqNfoc1QCrmIjv6rFfbuP1oy BpCwyKAkklBB6LwT9AbsgQ6qDsBrvvFXtgAjVBQvLJduCyUbS0HBpgQLMb7IpnaQX6 FKnQW3oHAXDlIazwwUdjmh8lTKUniCciLTdB4Rgfhz4a0L20BWB/DzSP59uU4r1xZh D8IP+9TwwEY6ZuA99wBdTDTvNgeI1BY4of5jzk+O7Ufv3CIY0uWMhJVX8tRUq0c3ic sNPQX/xgd/ay1gzO5c2uMNOM/hqL1a2b7ZS6V9c+XT8t8xy2rCYm59zvJJTPix+k5O IaMgaFiL/iGZw== From: sashiko-bot@kernel.org Subject: Re: [PATCH] arm64: dts: qcom: ipq5018: Correct CMN PLL reference clock rate Reply-To: sashiko-reviews@lists.linux.dev To: "George Moussalem via B4 Relay" Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260519-ipq5018-cmn-pll-rate-fix-v1-1-3c83a173c27f@outlook.com> References: <20260519-ipq5018-cmn-pll-rate-fix-v1-1-3c83a173c27f@outlook.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 19 May 2026 06:09:59 +0000 Message-Id: <20260519060959.CD84FC2BCB3@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The commit message incorrectly refers to 4.8 GHz as the 'CMN PLL re= ference clock rate'. -- commit 4cb93e818beccfa0a5e9ea288ba3c76a08ea178c Author: George Moussalem arm64: dts: qcom: ipq5018: Correct CMN PLL reference clock rate This commit corrects the CMN PLL clock rate configuration for the IPQ5018 in the device tree to 4.8 GHz, aligning it with the driver's updated clock divider math. > arm64: dts: qcom: ipq5018: Correct CMN PLL reference clock rate > > The correct CMN PLL reference clock rate for IPQ5018 is 4.8 GHz. > > The CMN PLL driver did not account for the ref clock divider which is 2 > for IPQ5018. Therefore, the computed rate was twice the actual output. This isn't a bug in the device tree changes, but does the commit message conflate the output rate with the input reference clock rate? In PLL terminology, the input reference clock for the IPQ5018 CMN PLL is 96 MHz. The 4.8 GHz value being configured via assigned-clock-rates-u64 is the output (or VCO) rate of the CMN PLL, rather than the reference clock rate. Could the subject and commit message be updated to clarify that 4.8 GHz is the output rate? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260519-ipq5018-cm= n-pll-rate-fix-v1-1-3c83a173c27f@outlook.com?part=3D1