Re: [PATCH v3 3/4] dt-bindings: i3c: dw: Add apb reset

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Adding a second item to `resets` and `reset-names` without specifying `minItems: 1` inadvertently makes the APB reset mandatory, which breaks schema validation for valid hardware configurations and older device trees.
--

commit f868716b21aa0a0740d04da18bdfc0d7495473fb
Author: Jisheng Zhang <jszhang@kernel.org>

dt-bindings: i3c: dw: Add apb reset

This commit adds a dt-binding for the APB reset signal, which is used to
reset the APB interface.

> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index 519797c6b4fe4..12845206772f7 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -38,10 +38,12 @@ properties:
>    resets:
>      items:
>        - description: Reset signal
> +      - description: APB interface reset signal
>  
>    reset-names:
>      items:
>        - const: core
> +      - const: apb

Does adding a second item without specifying minItems: 1 inadvertently make
the APB reset mandatory?

In dt-schema, when an items list is provided, the implicit minItems and
maxItems constraints default to the length of the list, which is now 2. Any
existing device tree or hardware configuration that specifies only the core
reset will fail dtbs_check validation.

The driver patch in the series retrieves the APB reset using
devm_reset_control_get_optional_exclusive_deasserted(), which suggests
that this reset is intended to be optional.

Should minItems: 1 be added to both resets and reset-names to accurately
reflect the hardware and maintain backward compatibility?

>  
>    interrupts:
>      maxItems: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519055105.13079-1-jszhang@kernel.org?part=3