Re: [PATCH v2 7/8] dt-bindings: arm: qcom: Document SA8797P Ride board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect placement of the new compatible block for `qcom,sa8797p` and `qcom,nord` in `arm/qcom.yaml`, breaking established logical grouping and sorting.
--

commit df8b4ac62d150d2753b5c52e4cf175018b410061
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

dt-bindings: arm: qcom: Document SA8797P Ride board

This commit documents the SA8797P Ride board, which is based on the Qualcomm
SA8797P SoC, an automotive variant of Nord. It adds the new compatible strings
to the arm/qcom.yaml device tree bindings file.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index af266d584fae6..ab25323c35811 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
[ ... ]
> @@ -303,6 +303,12 @@ properties:
>                - xiaomi,sagit
>            - const: qcom,msm8998
>  
> +      - items:
> +          - enum:
> +              - qcom,sa8797p-ride
> +          - const: qcom,sa8797p
> +          - const: qcom,nord
> +

This isn't a bug, but should this compatible block be grouped with the
other Snapdragon Automotive series SoCs?

The bindings generally maintain a logical grouping of devices by SoC family.
Could this be placed alongside similar automotive entries like sa8155p,
sa8540p, and sa8775p instead of here between the legacy mobile and networking
devices?

>        - items:
>            - enum:
>                - 8dev,jalapeno

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519063505.883379-1-shengchao.guo@oss.qualcomm.com?part=7