Re: [PATCH v6 3/6] dt-bindings: remoteproc: qcom: Document pas for SoCCP on Kaanapali and Glymur platforms

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `IPCC_MPROC_SOCCP` macro in the device tree example is defined without a value, resulting in missing cells after preprocessor expansion.
--

commit c89000efc2f275ab2ba31c246a7d1434f0474696
Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

dt-bindings: remoteproc: qcom: Document pas for SoCCP on Kaanapali and Glymur platforms

Document the component used to boot SoCCP on Kaanapali SoC and add
compatible for Glymur SoCCP which could fallback to Kaanapali. Extend
the "qcom,smem-states", "qcom,smem-state-names" in the pas-common
and add maxItems constraints for SMEM properties in the documents
that reference to pas-common.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml
> new file mode 100644
> index 0000000000000..ce18460a949fc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,kaanapali-soccp-pas.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,rpmh.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/mailbox/qcom-ipcc.h>
> +    #include <dt-bindings/power/qcom-rpmpd.h>
> +    #define IPCC_MPROC_SOCCP

Does this macro need a dummy integer value assigned to it, such as
#define IPCC_MPROC_SOCCP 19?

Since it is defined without a value, the C preprocessor will replace it
with an empty string when expanding the cells below.

> +
> +    remoteproc@d00000 {
> +        compatible = "qcom,kaanapali-soccp-pas";

[ ... ]

> +        glink-edge {
> +            interrupts-extended = <&ipcc IPCC_MPROC_SOCCP
> +                                         IPCC_MPROC_SIGNAL_GLINK_QMP
> +                                         IRQ_TYPE_EDGE_RISING>;
> +            mboxes = <&ipcc IPCC_MPROC_SOCCP
> +                            IPCC_MPROC_SIGNAL_GLINK_QMP>;

Because IPCC_MPROC_SOCCP is replaced with an empty string, will this
result in a missing cell for the client ID?

This would cause the properties to expand with a missing cell. A real device
tree using this structure might fail dtc compilation with a cell size
mismatch warning, as the ipcc hardware requires 3 interrupt cells and 2
mailbox cells. The generated DTB might also be functionally incorrect since
the required client ID is omitted.

> +
> +            label = "soccp";
> +            qcom,remote-pid = <19>;
> +
> +            /* ... */
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-knp-soccp-v6-0-cf5d0e194b5f@oss.qualcomm.com?part=3