Re: [PATCH 1/2] dt-bindings: hwmon/pmbus: Add Infineon XDP730

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The device tree example node is named `hwmon@11`, which uses a Linux-specific subsystem name instead of a generic hardware function name.
- [Low] The new device tree binding `infineon,xdp730.yaml` unnecessarily duplicates the schema of the existing `infineon,xdp720.yaml`.
--

commit e021e1d189da7e8470a3c273fdd6ec12f7ed6280
Author: Ashish Yadav <ashish.yadav@infineon.com>

dt-bindings: hwmon/pmbus: Add Infineon XDP730

Add documentation for the device tree binding of the XDP730 eFuse.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp730.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp730.yaml
> new file mode 100644
> index 0000000000000..a7361a07891c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,xdp730.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,xdp730.yaml#

Does this file needlessly duplicate the existing infineon,xdp720.yaml schema?

The properties, required fields, and constraints here appear identical
to infineon,xdp720.yaml. Creating duplicate YAML schema files for
devices in the same hardware family with identical constraints can
fragment the schemas.

Could the infineon,xdp730 compatible string be added to the enum in the
existing schema file instead?

[ ... ]

> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        hwmon@11 {

This isn't a bug, but does this node name follow the Devicetree
specification for generic names?

The spec requires node names to reflect the hardware function
(like efuse@11 or sensor@11), rather than pointing to a specific
OS subsystem like hwmon.

> +            compatible = "infineon,xdp730";
> +            reg = <0x11>;
> +            vdd-vin-supply = <&vdd_vin>;
> +            infineon,rimon-micro-ohms = <1098000000>;  /* 1.098k ohm */
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519075558.91466-1-Ashish.Yadav@infineon.com?part=1