Re: [PATCH v4 1/2] dt-bindings: display: panel: document the Renesas R63419 based dual-DSI video mode Display Panels

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The `reg` property is omitted from the `required` list.
- [Medium] Schema validation bypass for dual-DSI ports structure.
- [Medium] Flipped positive/negative voltage regulator assignments in the dt-binding example.
--

commit b7585613be27a07063e2837b4b237f47e298a1f5
Author: Neil Armstrong <neil.armstrong@linaro.org>

dt-bindings: display: panel: document the Renesas R63419 based dual-DSI video mode Display Panels

This commit documents the Renesas R63419 generic DDIC used to control
dual-DSI LCD panels, specifically for the Ayaneo gaming handheld devices.

> diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml
> new file mode 100644
> index 0000000000000..e4db01f88302c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml

[ ... ]

> +description:
> +  The Renesas R63419 is a generic DDIC used to control dual-DSI LCD panels.
> +
> +allOf:
> +  - $ref: panel-common.yaml#

Since this documents a dual-DSI panel, should this reference
panel-common-dual.yaml# instead?

Referencing panel-common-dual.yaml# would correctly enforce the dual-DSI
topology constraints and validate the ports structure for dual-link DSI
panels.

[ ... ]

> +required:
> +  - compatible
> +  - vdd-supply
> +  - vddio-supply
> +  - vsp-supply
> +  - vsn-supply
> +  - vci-supply
> +  - backlight
> +  - reset-gpios
> +  - ports

Should reg be included in this required list? 

The Renesas R63419 is a DSI peripheral and must be instantiated as a child
node under a DSI controller bus, which inherently requires a reg property for
its virtual channel. Omitting it from the required list allows incomplete
nodes to pass validation.

[ ... ]

> +            reset-gpios = <&gpio 176 GPIO_ACTIVE_LOW>;
> +
> +            vdd-supply = <&vdd_3v0_lcd>;
> +            vddio-supply = <&vdd_1v8_io>;
> +            vsn-supply = <&vdd_5v0_pos>;
> +            vsp-supply = <&vdd_5v0_neg>;

Are the voltage regulator assignments flipped in this example?

It looks like vsn-supply (Voltage Supply Negative) is mapped to the positive
regulator, while vsp-supply (Voltage Supply Positive) is mapped to the
negative one.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-topic-sm8650-ayaneo-pocket-s2-r63419-v4-0-b8929af5e951@linaro.org?part=1