Re: [PATCH v8 net-next 02/15] dt-bindings: net: dsa: add NETC switch

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The port node regex `^ethernet-port@[0-9a-f]$` is overly restrictive and may cause validation failures for standard DSA port names.
--

commit d14813f6031f2ea85ae295290215b9d354fa21d2
Author: Wei Fang <wei.fang@nxp.com>

dt-bindings: net: dsa: add NETC switch

This commit adds device tree bindings for the NETC switch, which is a PCIe
function of the NETC IP. It supports advanced QoS and TSN capabilities, and
connects to an internal ENETC port via a pseudo MAC to reduce power and delay.

> diff --git a/Documentation/devicetree/bindings/net/dsa/nxp,netc-switch.yaml b/Documentation/devicetree/bindings/net/dsa/nxp,netc-switch.yaml
> new file mode 100644
> index 0000000000000..1b35e4cbd0490
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/nxp,netc-switch.yaml

[ ... ]

> +  ethernet-ports:
> +    type: object
> +    patternProperties:
> +      "^ethernet-port@[0-9a-f]$":

Does this regex need to be less restrictive to support standard DSA port names?

The core DSA schema (dsa.yaml) allows port containers to be named ports or
ethernet-ports, and child ports to be named port@[0-9a-f]+ or
ethernet-port@[0-9a-f]+.

If a device tree uses the standard port@0 naming, the locally added clocks
and mdio properties will fail validation because they won't match this
schema override, falling back to the core DSA port schema which does not
allow them.

> +        type: object
> +        $ref: dsa-port.yaml#
> +
> +        properties:
> +          clocks:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260518082506.1318236-1-wei.fang@nxp.com?part=2