Re: [PATCH] dt-bindings: rtc: Convert rtc-cmos binding to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema restricts the `compatible` property to strictly `"motorola,mc146818"`, causing `dtbs_check` validation failures for existing in-tree device trees.
--

commit 2e9837eab33637d478720ff763bc9b81afee1cf3
Author: Teja Sai Charan Bellamkonda <tejaasaye@gmail.com>

dt-bindings: rtc: Convert rtc-cmos binding to YAML

This commit converts the rtc-cmos devicetree bindings from plain text to the
dt schema format.

> diff --git a/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml b/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/rtc-cmos.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: motorola,mc146818
> +
> +  reg:

Will this strict constraint cause dtbs_check validation failures for existing
in-tree device trees?

Looking at arch/x86/platform/ce4100/falconfalls.dts, the RTC node defines a
fallback compatible array:

	rtc@70 {
		compatible = "intel,ce4100-rtc", "motorola,mc146818";
		...
	};

Since the schema uses const instead of allowing an array, it appears this
might reject configurations containing the intel,ce4100-rtc variant. Should
the compatible property use a oneOf block to permit both the exact string
and the fallback array?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519095929.76011-1-tejaasaye@gmail.com?part=1