From: sashiko-bot@kernel.org
To: alice.guo@oss.nxp.com
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
Frank.Li@kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v2 3/3] arm64: dts: freescale: add ULP watchdog nodes for i.MX platforms
Date: Tue, 19 May 2026 11:12:12 +0000 [thread overview]
Message-ID: <20260519111212.C9AC6C2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260519105517.3638614-3-alice.guo@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Invalid full-width semicolon used to terminate the `bootph-all` property in `imx7ulp.dtsi`.
- [Low] Commit message prefix does not accurately reflect the changes.
--
commit bf6ac00d8852230a7eddc4b1f0a7d7bed4fb72cd
Author: Alice Guo <alice.guo@nxp.com>
arm64: dts: freescale: add ULP watchdog nodes for i.MX platforms
This commit adds ULP watchdog nodes to several i.MX device trees, bringing
in previously missing watchdog instances. All added nodes are disabled by
default and include the bootph-all property.
> arm64: dts: freescale: add ULP watchdog nodes for i.MX platforms
This isn't a bug, but the commit prefix specifically mentions arm64, while
the patch also modifies an arm 32-bit device tree in
arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi. Would it be better to split this
into separate patches for each architecture, or adjust the prefix?
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> index 1355feda1aa72..892799e1fe852 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
> @@ -325,6 +325,18 @@ smc1: clock-controller@40410000 {
[ ... ]
> + wdog2: watchdog@40430000 {
> + compatible = "fsl,imx7ulp-wdt";
> + reg = <0x40430000 0x10000>;
> + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&pcc2 IMX7ULP_CLK_WDG2>;
> + assigned-clocks = <&pcc2 IMX7ULP_CLK_WDG2>;
> + assigned-clock-parents = <&scg1 IMX7ULP_CLK_FIRC_BUS_CLK>;
> + timeout-sec = <40>;
> + status = "disabled";
> + bootph-all；
> + };
Does this property definition end with a full-width Unicode semicolon rather
than a standard ASCII semicolon? It appears this might lead to a syntax error
when the device tree compiler processes the file.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260519105517.3638614-1-alice.guo@oss.nxp.com?part=3
next prev parent reply other threads:[~2026-05-19 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 10:55 [PATCH v2 1/3] arm64: dts: imx94: fix DDR PMU interrupt number alice.guo
2026-05-19 10:55 ` [PATCH v2 2/3] arm64: dts: freescale: add bootph-all to ULP watchdog nodes for i.MX platforms alice.guo
2026-05-19 10:55 ` [PATCH v2 3/3] arm64: dts: freescale: add " alice.guo
2026-05-19 11:12 ` sashiko-bot [this message]
2026-05-20 2:36 ` [PATCH v2 1/3] arm64: dts: imx94: fix DDR PMU interrupt number Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519111212.C9AC6C2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=alice.guo@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox