Re: [PATCH 1/5] arm64: dts: imx91-9x9-qsb: remove unused property clock-frequency from mdio node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Removing a valid hardware description property because the current Linux driver does not use it violates Device Tree design principles.
--

commit c26ce3df4b77107e385684e72957f14db0b4c96d
Author: Joy Zou <joy.zou@nxp.com>

arm64: dts: imx91-9x9-qsb: remove unused property clock-frequency from mdio node

This commit removes the clock-frequency property from the mdio node, stating
that it is not implemented and removing it cleans up the device tree.

> diff --git a/arch/arm64/boot/dts/freescale/imx91-9x9-qsb.dts b/arch/arm64/boot/dts/freescale/imx91-9x9-qsb.dts
> --- a/arch/arm64/boot/dts/freescale/imx91-9x9-qsb.dts
> +++ b/arch/arm64/boot/dts/freescale/imx91-9x9-qsb.dts
> @@ -79,7 +79,6 @@ mdio {
>  		compatible = "snps,dwmac-mdio";
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> -		clock-frequency = <5000000>;

Could removing this property introduce a regression in the hardware
description?

The device tree is meant to be an OS-agnostic hardware description. The
clock-frequency property is standard for this node and accurately describes
the hardware's intended MDIO bus speed of 5MHz.

Removing valid hardware properties due to temporary software limitations
strips away useful context that alternative operating systems, bootloaders
like U-Boot, or future Linux driver enhancements might rely on.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-b4-imx91-qsb-opt-v1-0-9b416d2dc224@nxp.com?part=1