From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C46614C042E for ; Tue, 19 May 2026 12:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779192158; cv=none; b=dnQY+tY/WjLAp0zE8bVugwrzVd4DasuU/jtg73s4XRzzaJm5qqi7T+zPk6rxilzXEh1eJ61vje1hwokVpw90ik4ypbasiBipmr5bDNH/Wbsmgc7/ZjbCWZKA/oFRgOsbkXRmRmg+x/QcxQMw9aMRGmOBTEU1qaji+MG8Y3n9THo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779192158; c=relaxed/simple; bh=4QhiP/O5Cduyi8JFpsxktoqRpBVXZeNxxdFhkjZreyI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=s6BfE5NaflSBZkErUbzryVSjTwyaz2YkDXJ7j4RVKQkWtPHxBt9Tqog5bwT5KA+zIo+AOJpdTF3eLQW0aGO2/00W4vN5HQcOU4Qy/jfQy60oPkGtD6fQ/KY1Xi2YF3eo7syE38/r5wQREfeEMQU+Ge4bzRvtRZCyTWubeGaQgAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DYZjSSQb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DYZjSSQb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C84CC2BCB3; Tue, 19 May 2026 12:02:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779192158; bh=4QhiP/O5Cduyi8JFpsxktoqRpBVXZeNxxdFhkjZreyI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=DYZjSSQbjjnoJpDMXBywq3QDX1qwMIZ3/6/oCyP+ZWvxNkGXZcT7IrA/hnCsZNIKt WNVeE8YLSo3wMKbhEjY94+srl+JHTHrYUQmuW8PxoTRWkd5dF9au07Z78OfIQSCYXy 0WWfFJ6ER1TptB8yOTKflUI+SkwKsHcWZ+EAuFtZDczUFgvXjSedjMO40gfHINy3y9 QkZTNAsO/P6bsExWayhllK91l02h4p3ReBjO09N7j62C6/Sdu3GOI81G9Cb/DLSz6w eXwOrkp7k65YgqsCz5MPXdX/pE4QFeHIgPuInZVT1tHzkVhL6yZYOCzxldpak10l7C Tilbt9fW/cqUQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 3/5] arm64: dts: qcom: Add Shikra CQ7790M SoM platform Reply-To: sashiko-reviews@lists.linux.dev To: "Komal Bajaj" Cc: robh@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org In-Reply-To: <20260519-shikra-dt-v2-3-c01b90fb4395@oss.qualcomm.com> References: <20260519-shikra-dt-v2-3-c01b90fb4395@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 19 May 2026 12:02:37 +0000 Message-Id: <20260519120238.1C84CC2BCB3@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] The SoM device tree partially defines PMIC regulators (LDOs) but c= ompletely omits their internal parent SMPS regulators (S3, S4) and the requ= ired supply linkage properties. - [High] The SoM integrates the PM4125 PMIC, but the device tree include fo= r the PMIC's SPMI components (`pm4125.dtsi`) is missing. -- commit 1edd30ea88da411f667f786ef5494cebf1420c78 Author: Komal Bajaj arm64: dts: qcom: Add Shikra CQ7790M SoM platform This commit adds the device tree include for the CQ7790M variant of the Shikra System-on-Module. It includes the common shikra.dtsi and adds PM4125 PMIC regulator definitions specific to this variant. > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi b/arch/arm64/bo= ot/dts/qcom/shikra-cqm-som.dtsi > new file mode 100644 > index 0000000000000..401e71720519d > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi > @@ -0,0 +1,112 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#include "shikra.dtsi" The commit message mentions the SoM integrates the PM4125 PMIC, but is pm4125.dtsi supposed to be included here as well? Without including the PMIC's SPMI components (like pm4125_gpios, pm4125_pwrkey), it seems carrier boards won't be able to address or utilize these peripherals. > + > +&rpm_requests { > + regulators { > + compatible =3D "qcom,rpm-pm2250-regulators"; > + > + pm4125_s2: s2 { > + regulator-min-microvolt =3D <1000000>; > + regulator-max-microvolt =3D <1200000>; > + }; Does this regulator node need to define the internal parent SMPS regulators like s3 and s4, as well as the vdd_X-supply linkage properties for the child LDOs? The driver drivers/regulator/qcom_smd-regulator.c expects supply mappings f= or pm2250 (e.g., vdd_l1_l2_l3_l5_l6_l7_l8_l9_l10_l11_l12). Without representing this fixed internal power routing in the SoM's device tree, the core framework might not be able to correctly manage the parent supply voltages and states when child LDOs are toggled. > + > + pm4125_l3: l3 { > + regulator-min-microvolt =3D <624000>; > + regulator-max-microvolt =3D <650000>; > + }; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260519-shikra-dt-= v2-0-c01b90fb4395@oss.qualcomm.com?part=3D3