Re: [PATCH v3 1/3] regulator: dt-bindings: Add Unisoc SC2730 PMIC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The YAML binding schema requires the `compatible` property but completely omits the `properties:` block to define it.
--

commit 965b6e885b7ba5fbecce0029c11926bf606c2f72
Author: Otto Pflüger <otto.pflueger@abscue.de>

regulator: dt-bindings: Add Unisoc SC2730 PMIC

Add bindings for the regulators found in the Spreadtrum/Unisoc SC2730
PMIC, used e.g. with the UMS512 and UMS9230 SoCs.

> diff --git a/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml b/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml
> new file mode 100644
> index 0000000000000..5b91c7b7f3ee3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/sprd,sc2730-regulator.yaml

[ ... ]

> +  "^ldo-vddrf(1v25|18)$":
> +    type: object
> +    $ref: regulator.yaml#
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +
> +additionalProperties: false

Is there a missing properties block to define the compatible property?

The schema requires compatible and specifies additionalProperties: false.

Under schema validation rules, additionalProperties: false forbids any
properties not explicitly listed in properties or patternProperties. Because
compatible is not defined and does not match the regexes in
patternProperties, any device tree node containing the required compatible
string will be rejected as having a forbidden additional property.

Could this create a regression where the compatible property is required
but forbidden, preventing any device tree node from passing validation
against this schema?

> +...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-sc2730-regulators-v3-0-5bf0e02507e3@abscue.de?part=1