Re: [PATCH v12 1/6] dt-bindings: iio: adc: add AD4691 family

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding defines GPIO controller capabilities but omits `gpio-controller` and `#gpio-cells` from the `required` list.
--

commit 96f168db5f8432c094e1917f0e5c69f84e070941
Author: Radu Sabau <radu.sabau@analog.com>

dt-bindings: iio: adc: add AD4691 family

This commit adds device tree bindings for the Analog Devices AD4691 family
of multichannel SAR ADCs. It describes the hardware connections including
power domains, optional PWM for CNV Burst Mode, reset GPIO, and GP pins
usable as interrupts or GPIOs.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
> new file mode 100644
> index 0000000000000..af28a0c1cfa9e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml
[ ... ]
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  '#trigger-source-cells':
> +    description:
> +      This node can act as a trigger source. The single cell in a consumer
> +      reference specifies the GP pin number (0-3) used as the trigger output.
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - avdd-supply
> +  - vio-supply

Should gpio-controller and #gpio-cells be added to the required list here?

When a hardware variant provides GPIO controller capabilities, these
properties generally need to appear in the required list.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-ad4692-multichannel-sar-adc-driver-v12-0-5b335162aa51@analog.com?part=1