From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A21933EA942 for ; Tue, 19 May 2026 15:55:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779206135; cv=none; b=s8tlU0Bveha57LUUUb7L/uaKuhxUlCX8jRMuDejysrmtP7EZEs2qO0o7PudCtcqaoC1n8fl/TAXhBqJhdtHMKlCc2yMM0BZ0Q3V3BqpRnfmtJ1Da6nBKSjTOywN9rTZ4doPyeyZmRc+qsHvDYXeUc98+2xM5DoNsLoMV3/juci4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779206135; c=relaxed/simple; bh=TU186bkJS+0q/wiN0iWka77F9yWFWMnZwRrCzCJxqok=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=IKqRkcF/mz6pNCxk9v5nVZmN7zeR+Fkgb6jiKOlUTuTs57YvSqko/eHfAfgoiyqR22AP+5gfnnnZ4bREuiXLXvM0GQBFM+xVzyYDyfFv0evlgSNHMpw47ARcpvFl05Qwg30IjyVP0FixPwBnHFw1X4GClbIjXFTsC90X/GIYlgo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CXjEC3RU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CXjEC3RU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF179C2BCB3; Tue, 19 May 2026 15:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779206135; bh=TU186bkJS+0q/wiN0iWka77F9yWFWMnZwRrCzCJxqok=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=CXjEC3RUZB1yYZRdcbnTKOOsKiW5F16ImU+AyMgMlTVx11/LzKYnA7IGGjc4wy26I vamxdNy/cfgVzzif80ocqhqlaoGU+aJM8VVky5YxSZoNuTl6NruBrwwGyfUR9W67nd EsGaGNA+DYX3VC59HGQYIaqeEW0di+Cs0ZRLzICcg6/O6LK+tw/2Y+4diuZg0DGNlv bGRErJG+/E0AG5wLxxwnit3OEDKl7dUk6ynfmoKt89zGFXktuVp+h85daa+swiXBHA NXxDRSe2FG9JEwQ9SkmcFtkWOdPBgWl2vWcgvtHtSkYLJQQlym87CvoGhl9NbWMRV1 jAN9JyprUdvpQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add AD5529R Reply-To: sashiko-reviews@lists.linux.dev To: "Janani Sunil" Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org In-Reply-To: <20260519-ad5529r-driver-v3-1-267c0731aa68@analog.com> References: <20260519-ad5529r-driver-v3-1-267c0731aa68@analog.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 19 May 2026 15:55:34 +0000 Message-Id: <20260519155534.BF179C2BCB3@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The `patternProperties` regex for child channel nodes incorrectl= y expects decimal unit addresses instead of hexadecimal, causing valid devi= ce tree nodes to fail validation. -- commit 137584b720b9b8966a6cb2fb8c6b4d98d2bf3d55 Author: Janani Sunil dt-bindings: iio: dac: Add AD5529R This commit adds devicetree bindings for the AD5529R 16-channel 12/16-bit high voltage DAC. It defines properties for programmable output ranges, SPI communication, and GPIO pins. > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml b= /Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml > new file mode 100644 > index 0000000000000..eb66f6ca063dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml [ ... ] > +patternProperties: > + "^channel@([0-9]|1[0-5])$": [Severity: Medium] Does this pattern incorrectly expect decimal unit addresses instead of hexadecimal? According to the Devicetree specification, node unit addresses must be written in lower-case hexadecimal without a "0x" prefix. Since the AD5529R has 16 channels, valid reg values of 0 through 15 correspond to unit addresses 0 through f (e.g., channel@a). This regex expects decimal strings 10 through 15 for values 10-15. If a user correctly writes channel@a for channel 10, it will fail to match this regex. Because the schema enforces unevaluatedProperties: false at the top level, these nodes will be rejected by validation tools. Alternatively, if the user incorrectly names the node channel@10 to pass schema validation, dtc will produce a unit address format mismatch warning since "10" is evaluated as hex 16. Could the regex be updated to match single-character hexadecimal values (e.g., "^channel@[0-9a-f]$")? > + type: object > + description: Child nodes for individual channel configuration --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260519-ad5529r-dr= iver-v3-0-267c0731aa68@analog.com?part=3D1