Re: [PATCH v4 1/2] dt-bindings: nvmem: airoha: add SMC eFuses schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema is missing the compatible string for the Airoha AN7583 SoC, despite it being explicitly mentioned in the commit message.
--

commit 4691b687a514217a385c7b7725536b71c206a6c2
Author: Christian Marangi <ansuelsmth@gmail.com>

dt-bindings: nvmem: airoha: add SMC eFuses schema

This commit adds a new device tree binding schema for the Airoha SMC
eFuses. It documents the access method for the eFuse banks via SMC
commands for the new Airoha SoCs.

> Add Airoha SMC eFuses schema to document new Airoha SoC AN7581/AN7583
> way of accessing the 2 eFuse bank via the SMC command.

[Severity: Medium]
Is the AN7583 SoC supposed to be included in the schema? The commit
message mentions both AN7581 and AN7583, but the schema below only documents
the AN7581.

> diff --git a/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml b/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml
> new file mode 100644
> index 0000000000000..c52f8d4bec392
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/airoha,smc-efuses.yaml
[ ... ]
> +title: Airoha SMC eFuses
> +
> +description: |
> +  Airoha new SoC AN7581 expose banks of eFuse accessible
> +  via specific SMC commands.

[Severity: Medium]
Should AN7583 also be mentioned in the description here to match the
details in the commit message?

[ ... ]
> +properties:
> +  compatible:
> +    enum:
> +      - airoha,an7581-efuses

[Severity: Medium]
Should airoha,an7583-efuses be included in this enum if the binding is
intended to support the AN7583 SoC? 

If AN7583 uses this block, omitting its specific compatible string might
cause device tree validation to fail for valid AN7583 device trees.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519152807.29407-1-ansuelsmth@gmail.com?part=1