From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: Add Eliza CQS SoM platform
Date: Tue, 19 May 2026 16:37:20 +0000 [thread overview]
Message-ID: <20260519163722.306FDC2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260519-eliza-dts-qcs-evk-v2-2-ad7303659d24@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undefined labels referenced in the device tree (`&sdhc_1`, `&remoteproc_adsp`, `&sdc1_default`, and `&sdc1_sleep`) will cause a Device Tree Compiler (DTC) build failure.
--
commit 7ca90443e3e2a64f1e18e601c91556491fa0f444
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
arm64: dts: qcom: Add Eliza CQS SoM platform
This commit adds the Eliza CQS SoM DTSI so it can be included by the EVK
board DTS. It describes the regulators and board clocks, enables eMMC
support through SDHC1, specifies the ADSP firmware, and enables the ADSP
remoteproc.
> diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> new file mode 100644
> index 0000000000000..5e0f9c1698f88
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
[ ... ]
> +&remoteproc_adsp {
[Severity: Low]
Are the labels &remoteproc_adsp, &sdhc_1, &sdc1_default, and &sdc1_sleep
defined in the base eliza.dtsi?
It appears that these labels are not defined anywhere in the SoC tree,
nor are they provided by any included .dtsi files. This will cause a
Device Tree Compiler (DTC) build failure due to undefined labels.
> + firmware-name = "qcom/eliza/adsp.mbn",
> + "qcom/eliza/adsp_dtb.mbn";
> +
> + status = "okay";
> +};
> +
> +&sdhc_1 {
> + vmmc-supply = <&vreg_l12b>;
> + vqmmc-supply = <&vreg_l1d>;
> + pinctrl-0 = <&sdc1_default>;
> + pinctrl-1 = <&sdc1_sleep>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-eliza-dts-qcs-evk-v2-0-ad7303659d24@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-05-19 16:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 16:09 [PATCH v2 0/3] arm64: dts: qcom: Add Eliza CQS EVK support Abel Vesa
2026-05-19 16:09 ` [PATCH v2 1/3] dt-bindings: arm: qcom: Document Eliza CQS SoM and its EVK board Abel Vesa
2026-05-20 10:10 ` Krzysztof Kozlowski
2026-05-19 16:09 ` [PATCH v2 2/3] arm64: dts: qcom: Add Eliza CQS SoM platform Abel Vesa
2026-05-19 16:37 ` sashiko-bot [this message]
2026-05-20 10:11 ` Krzysztof Kozlowski
2026-05-19 16:09 ` [PATCH v2 3/3] arm64: dts: qcom: Add Eliza CQS EVK board Abel Vesa
2026-05-20 10:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519163722.306FDC2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox