Re: [PATCH v2 1/4] dt-bindings: firmware: qcom,scm: Add minidump SRAM property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing type definition ($ref) for the `sram` device tree property.
- [Low] Violation of device tree naming conventions by using the generic name `sram` for a vendor-specific property.
--

commit 657534134734a0a9c527c2bb59cf5ebc948cf8b5
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

dt-bindings: firmware: qcom,scm: Add minidump SRAM property

This commit adds a sram property to the Qualcomm SCM binding. It describes
a region in always-on SRAM where the minidump download destination value is
written so boot firmware can read it on warm reset.

> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> @@ -127,6 +127,13 @@ properties:
>            - description: offset of the download mode control register
>      description: TCSR hardware block
>  
> +  sram:

[Severity: Low]
Would it be better to use a vendor-specific name for this property, such as
qcom,minidump-sram or qcom,dload-sram?

Using the generic sram name for a highly specialized firmware feature might
prevent the qcom,scm node from using sram for general-purpose SRAM attachments
in the future.

> +    description:
> +      Phandle to a region in always-on SRAM used to store the download
> +      mode value for boot firmware to read before DDR is initialised on
> +      the next warm reset.
> +    maxItems: 1

[Severity: Low]
Should this property explicitly reference a standard type, such as
$ref: /schemas/types.yaml#/definitions/phandle?

Because the property name lacks a standard type-implying suffix, specifying
maxItems: 1 alone might treat it as an untyped JSON array. Devicetree
validation tooling could fail to enforce that the value is a valid phandle,
allowing malformed values to pass the dt_binding_check silently.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com?part=1