From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A81223D75AB; Wed, 20 May 2026 18:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779303335; cv=none; b=gM0EwEwkifwAbhvsvXx1xLqmibW8SOdctsAQvk8NYaPAvRWJV9LU8frnl7rWbFYQAsf9DW8K1uGWW5gBjx4Ee2kMLQTqFwmv+WV+72MT8YliB0HC0MHmhIeE8TzWYVB5477r80B+IolIHh0W638njZ3Uyz90WEt4cKQD3dmAjy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779303335; c=relaxed/simple; bh=PvpeF/Zoun/FX1KkahgKET3g0uHQyd8hBFJoc4f5kUE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dRdUEwLIZhm8/7Zb8EQYEL5p3T48Q7nPcAl97dfD28zz7cb1nFU18wh/RfF+vbUt36Usw4gwL9s+Wp9OTuGmWWt8iXpbkLHVDY8iGLP9TeTWoMps8MZRDpIvgOpjaGKGMaXWVTIw2raKs19PMh3RTom/psQXO6X/xZnyzxOmzO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=d3HC1AWl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="d3HC1AWl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 108B21F000E9; Wed, 20 May 2026 18:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779303334; bh=1T+Q/YxtQARU2EGQLE/zHDY4XgcSiULTKufiyFMk81o=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=d3HC1AWlxYQloLRdwFfkhaO9j224EwZJKTWuqbNerYPPwboNaP5Oz+iENzlzxFIap aB83fyHfHkO46WDersl/s2y9fMKNnVWY7cjunQ3dZWU8yCNtPQ19Yr5yJ/gO+07XZa nEA65mrqtesRALxniBsxDYR26TgwmwQbhOQ2kWquww7WOG+HhUp2rhuD0XkQpnUKl4 3jcPM5N7E+loqNENnYvCO7XLTC/PSQpsIvSfJezjYB+z5Mb6JhpjxAe0MsCcyo7EgJ zbX+IR/im+BQAIPoSDd/EOu68/1bNkHfVz3edQcj3+K+CFV6P24opy4+L1dj3HWqu9 P6iMyHvEgXW/g== Date: Wed, 20 May 2026 19:55:29 +0100 From: Conor Dooley To: Drew Fustini Cc: Tomasz Jeznach , Joerg Roedel , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , iommu@lists.linux.dev, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Joel Stanley , Joerg Roedel , Nicholas Piggin Subject: Re: [PATCH v2] dt-bindings: iommu: riscv: Add bindings for Tenstorrent RISC-V IOMMU Message-ID: <20260520-imminent-graded-6e1f0f4c54d0@spud> References: <20260520061855.1623468-4-fustini@kernel.org> <20260520-frayed-fervor-7c887193ab19@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XDMycSDARlTDf9SM" Content-Disposition: inline In-Reply-To: --XDMycSDARlTDf9SM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 20, 2026 at 11:14:32AM -0700, Drew Fustini wrote: > On Wed, May 20, 2026 at 05:17:41PM +0100, Conor Dooley wrote: > > On Tue, May 19, 2026 at 11:16:28PM -0700, Drew Fustini wrote: > > > +allOf: > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - tenstorrent,riscv-iommu > > > + then: > > > + properties: > > > + reg: > >=20 > > > + items: > > > + - description: IOMMU base registers > > > + - description: Tenstorrent IOMMU machine mode registers. > >=20 > > Should this also have minItems: 2? >=20 > I think items: with 2 items implies minItems: 2 but I see your later > point about the description and names don't belong in the allOf: block. It would usually, but this is a conditional portion of a wider binding that you've modified to look like | reg: | minItems: 1 | maxItems: 2 outside the conditional section, and since you don't further constrain reg in the conditional section, this minItems: 1 applies. --XDMycSDARlTDf9SM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCag4DoAAKCRB4tDGHoIJi 0i52AQCcMVQtjCAMXGJzQtwBxYsFksRtUfjkaDGhaqziPvWuBQD/T3ApAlZSXRoR lowYATvKW0j7qswukibEBKJMYExAhgw= =Cpyi -----END PGP SIGNATURE----- --XDMycSDARlTDf9SM--