From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D594370D70; Wed, 20 May 2026 10:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779272873; cv=none; b=W8vaku3cNK3tR+weNC1+CPg+333oMpmXyLYoUuhabXGTtyh8sndrUbp0UYjrMi0xNCKi1AnhG5QEVX6yry/PCAVZOd7+LhXhRDHbdPeP89+4J7U0n6KmxpZ66rdk+JFT28x8X1Gi/G2oBBvfLSiFupzmJCXoWTzo0tstw83hxdM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779272873; c=relaxed/simple; bh=BnPTcSmpVRwDkfqkdwbPpoZ5ptgPI7d8UI+1EVqrf4w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BUxXneujIQnFv3JnHW4KokIrbedLPxe1zdN6YzvPREs4A5UzET9X8MQh9kuCcYZZN6KMLSAkYgaUqMfWayPzCTiRuC6qkqQtuV2K+TmVnLrwRHJzIGQXKelKlW9zHj6kPoZaVeUhpW2KLFtqkcQNnPXD/tHfvxjE/NJMRDIjbXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g/xu3rRH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g/xu3rRH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 114581F00893; Wed, 20 May 2026 10:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779272863; bh=PXuhWMBW4R5WVatyNftyCjjSzFGtkZFEfoCUnhl2YYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=g/xu3rRHJHu78ueoKVqHqsNSFH5iH0jAd0+T7Bl68bmI2uDaIS9NPLPkCLhICPRRk 3fKuRUCz1NlWypyP0dCZnYAwgHV1kIr60pui+naT/ygRsU+GWlto+qeQGBl/sda2lV oB+4Zsk5thvkaYxMk9N0MLwXZQf/ZHObTVA7UwRQhd044/Vr5hjLbSD0H+oovfwTZL e3NR0L6fA5IvKFYILe+BKK4vzXAqApu9mi41Eifq6BgQke4BWGNaUnA375XnjrCtjQ tdx70pl0qhPDvt70PeF9baq2MpeQsRV1dKf/q5eNww43ju0PTgjWQo1Jb2jHwrQjXC no24TLqpS8KUQ== Date: Wed, 20 May 2026 12:27:41 +0200 From: Krzysztof Kozlowski To: Vignesh Viswanathan Cc: Saravanan Sekar , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: regulator: mps,mp8899: Add binding for MP8899 PMIC Message-ID: <20260520-passionate-handsome-dogfish-9fc65b@quoll> References: <20260519-mp8899-regulator-driver-v1-0-30d14421b7f1@oss.qualcomm.com> <20260519-mp8899-regulator-driver-v1-1-30d14421b7f1@oss.qualcomm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260519-mp8899-regulator-driver-v1-1-30d14421b7f1@oss.qualcomm.com> On Tue, May 19, 2026 at 11:51:05PM +0530, Vignesh Viswanathan wrote: > Add devicetree binding documentation for the Monolithic Power Systems > MP8899 PMIC, which provides four synchronous buck converters controlled > over I2C. Please use subject prefixes matching the subsystem. You can get them for example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > > Signed-off-by: Vignesh Viswanathan > --- > .../devicetree/bindings/regulator/mps,mp8899.yaml | 66 ++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml b/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml > new file mode 100644 > index 000000000000..3225c92db2c8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/mps,mp8899.yaml > @@ -0,0 +1,66 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/mps,mp8899.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Monolithic Power System MP8899 PMIC > + > +maintainers: > + - Vignesh Viswanathan > + > +properties: > + $nodename: > + pattern: "^pmic@[0-9a-f]{1,2}$" Drop nodename. > + compatible: > + enum: > + - mps,mp8899 > + > + reg: > + maxItems: 1 > + > + regulators: > + type: object > + > + description: | Do not need '|' unless you need to preserve formatting. > + list of regulators provided by this controller, must be named > + after their hardware counterparts BUCK[1-4] Drop description. > + > + patternProperties: > + "^buck[1-4]$": > + type: object > + $ref: regulator.yaml# > + Droip blank line > + unevaluatedProperties: false > + > + additionalProperties: false Put this additionalProps after type. > + > +required: > + - compatible > + - reg > + - regulators Best regards, Krzysztof