From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5C643E1717; Wed, 20 May 2026 15:17:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779290225; cv=none; b=O6DcyWS8eu+dJZhKFpqKuN8Xj7n02nwUjCbtMgeUbtp78SRQVEXJEvI7wZHefGnrUhjsNn3OWWcYJW/s6Jsia6HvfF1FTdP0H1TP1fwwqILIGeItBE+YUju2IK7NnkI4oXjMHnaXMZhGInHYw4F6IDiYQtsS/98qOyfaxxXVQ3U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779290225; c=relaxed/simple; bh=0B41DTrnN6xq1xALNp2+MWs4snjweA430oCHYw0Mhc0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fyYOHS1QQL/dcMJqgRJToBZhKfZOoB6AMXDcxw6K+MK+DU1ONc+z7koNl5PjLUEewWWdGvUnA7UdytCHoy/cV8uI9yPPo+ETHMrF5SdtY1pbIAacA7yOfBXh2NTCGdXu7m6o6vUJSwFmP3cmE8OJ6k7InXEHV4kvOqsO9TeH80c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EqmL26Qn; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EqmL26Qn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 697C41F00893; Wed, 20 May 2026 15:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779290223; bh=Lsy/ENfzpH9yPpbKWh0LfhF3I3NPmtNTsPfNvR1IAnc=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=EqmL26Qn/w8XlKk17HK5iYjzAKMWaH9dAwY1MALO7q4Sk0OvsTDoMX+K/gibDfO53 HIWVuiQybuO6SN1yxFqs10im9wT9P/fmS/ENuR2agHBs/KgeUtKQ/Dpwc6/xeSXVbw eKdsUu1bLSGTJTZEgsfcqs4JZqMWR4DZqXS0Az1uumHWJp8tZMU0BE2BR25h0HZPji fzip1/hJupUmknogez76wQoRZv9JKICY6sHMeFj7kp5zt7u74gRplE+fIIJH/Ihb0S Cxk+XHFAOm70Rib/bwa54DqyJUNcQ47liDO5h8a4Qe6hTIy7qIX8jU1XPYIcEtR8Vr 2NHkCaJ9s6CZw== Date: Wed, 20 May 2026 16:17:00 +0100 From: Conor Dooley To: "Jose A. Perez de Azpillaga" Cc: linux-iio@vger.kernel.org, Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , devicetree@vger.kernel.org Subject: Re: [PATCH v3 1/2] dt-bindings: iio: light: add Broadcom APDS9999 Message-ID: <20260520-rockband-ribcage-3fd3f8a232f5@spud> References: <12b145839a1a9c5381946a9e5237bfe6fe0ae9a7.1779181370.git.azpijr@gmail.com> <20260519-overdrawn-cofounder-59752aa87d4f@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GM4CVlOY0jZv8GS4" Content-Disposition: inline In-Reply-To: --GM4CVlOY0jZv8GS4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 20, 2026 at 10:56:19AM +0200, Jose A. Perez de Azpillaga wrote: > On Tue, May 19, 2026 at 06:30:20PM +0100, Conor Dooley wrote: > > On Tue, May 19, 2026 at 11:23:13AM +0200, Jose A. Perez de Azpillaga wr= ote: > > > Add Device Tree binding for the Broadcom APDS9999 ambient light > > > and proximity sensor. A separate binding file is used rather > > > than merging with avago,apds9300.yaml because the APDS9999 > > > has an additional vled-supply for the VCSEL. > > > > > > The APDS9999 features individual R, G, B, and IR channels with > > > a green channel that uses optical coating to approximate the > > > human eye spectral response for ALS/lux measurements. Calibrated > > > RGB color sensing is not yet implemented in the driver. > > > > > > Signed-off-by: Jose A. Perez de Azpillaga > > > --- > > > .../bindings/iio/light/brcm,apds9999.yaml | 54 +++++++++++++++++= ++ > > > MAINTAINERS | 6 +++ > > > 2 files changed, 60 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/iio/light/brcm,= apds9999.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds999= 9.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml > > > new file mode 100644 > > > index 000000000000..4d9e9aff8894 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml > > > @@ -0,0 +1,54 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/light/brcm,apds9999.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > +title: Broadcom APDS-9999 Digital Proximity and RGB Sensor > > > + > > > +maintainers: > > > + - Jose A. Perez de Azpillaga > > > + > > > +description: | > > > + Broadcom APDS-9999 is a digital proximity and RGB sensor with > > > + ambient light sensing (ALS) capability. The device uses individual > > > + R, G, B, and IR channels plus a Vertical Cavity Surface Emitting > > > + Laser (VCSEL) for proximity detection. > > > + > > > + Datasheet: https://docs.broadcom.com/docs/APDS-9999-DS > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - brcm,apds9999 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + vdd-supply: true > > > + > > > + vled-supply: > > > + description: VCSEL power supply > > > > Why does the name in the description disagree with the name in the > > property? If the pin is called vcsel, please call the property that. > > >=20 > will rename to vcsel-supply in v4. Sounds good. pw-bot: changes-requested Thanks, Conor. --GM4CVlOY0jZv8GS4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCag3QbAAKCRB4tDGHoIJi 0mYvAQDqHZc5TmtSYWbDEcD8/RF85FfvCJfwal3xzDl8nMXJuQD/QwuBiChbA8+M /txipSVNp0PHq6z9E5Cb3UubQVD/FAE= =l6+B -----END PGP SIGNATURE----- --GM4CVlOY0jZv8GS4--