Re: [PATCH] dt-bindings: clock: via,vt8500: Convert to DT Schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Missing default value for `divisor-mask` property in the DT schema.
- [Low] Example node uses a deprecated name for `fixed-clock`, which will cause schema validation warnings.
--

commit 5bd68ac4f98e8a51a2fee1d1c82c98071336d42f
Author: Udaya Kiran Challa <challauday369@gmail.com>

dt-bindings: clock: via,vt8500: Convert to DT Schema

Convert the VIA/Wondermedia VT8500 and Wondermedia WM8xxx series SoCs clock
controller binding from the legacy text format to DT schema.

> diff --git a/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml b/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
> new file mode 100644
> index 0000000000000..9c312d11a6a7b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/via,vt8500-clock.yaml
[ ... ]
> +  divisor-mask:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Bitmask describing the divisor field inside divisor-reg.

[Severity: Low]
The legacy text binding explicitly specified that divisor-mask defaults to
0x1f if not specified. Can we include a default value here to ensure the
dt-schema validation tools can infer it?

[ ... ]
> +examples:
> +  - |
> +    / {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ref25: ref25M {

[Severity: Low]
Does this node name cause schema validation warnings? The core
fixed-clock.yaml schema requires node names to match the pattern
^clock-([0-9]+|[a-z0-9-]+)$.

Naming it clock-25000000 might be better to avoid warnings during
make dt_binding_check.

> +            compatible = "fixed-clock";
> +            #clock-cells = <0>;
> +            clock-frequency = <25000000>;
> +        };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520025131.17772-1-challauday369@gmail.com?part=1