Re: [PATCH 1/3] dt-bindings: usb: typec: Add Cypress CYPD6129 UCSI controller compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] The new device tree example assigns an unauthorized value to the 'firmware-name' property, which violates the schema constraints.
- [Low] The DT example fails to compile due to an undefined macro 'GPIO' and an undefined phandle label '&node'.
- [Low] The second device tree example is missing its parent bus node, resulting in an invalid 'reg' property length and incorrect node context.
--

commit 911d8bba6bd4939c0495f237ef6ddd1854af3dd2
Author: Akash Kumar <akash.kumar@oss.qualcomm.com>

dt-bindings: usb: typec: Add Cypress CYPD6129 UCSI controller compatible

This commit documents the "cypress,cypd6129" compatible string for the
Cypress/Infineon EZ-PD CCGx UCSI controller. It allows the new compatible
and permits the existing "cypress,cypd4226" fallback.

> diff --git a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> --- a/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
> +++ b/Documentation/devicetree/bindings/usb/cypress,cypd4226.yaml
[ ... ]
> @@ -63,10 +69,42 @@ examples:
>    - |
>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>      i2c {
> -      #address-cells = <1>;
> -      #size-cells = <0>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        #interrupt-cells = <2>;
> +
> +        typec@8 {
> +            compatible = "cypress,cypd6129";
> +            reg = <0x08>;
> +            interrupt-parent = <&node>;
> +            interrupts = <GPIO IRQ_TYPE_LEVEL_LOW>;

[Severity: Low]
Will this example compile successfully? The label "node" is not defined
anywhere in the example, and "GPIO" is not a defined C preprocessor macro.
This typically causes the device tree compiler to fail with syntax and
undefined reference errors during dt_binding_check.

> +            firmware-name = "ccg_primary.cyacd2";

[Severity: Low]
Will this cause dt_binding_check to fail schema validation? The schema
restricts the firmware-name property to an enum of specific values like
"nvidia,gpu" and "nvidia,jetson-agx-xavier". Using "ccg_primary.cyacd2"
appears to violate this constraint.

> +            #address-cells = <1>;
> +            #size-cells = <0>;
[ ... ]
> +    };
> +
> +  - |
> +    typec@8 {

[Severity: Low]
Does this second example lack a valid parent bus wrapper?

The original typec@8 example was wrapped inside an i2c node that provided
the required #address-cells and #size-cells context. Without the parent
node, the reg = <0x08> property will trigger a missing cells error during
dt_binding_check.

>          compatible = "cypress,cypd4226";
>          reg = <0x08>;
>          interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520093902.2064730-1-akash.kumar@oss.qualcomm.com?part=1