Re: [PATCH v2 3/3] arm64: dts: freescale: imx95-aquila: Add Clover carrier board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The flexspi1 flash node incorrectly uses Cadence QSPI specific properties (cdns,*) with an NXP FlexSPI controller.
--

commit 58fa26ce8327e303e6d4b9e4915178ba8d66e5b7
Author: Antoine Gouby <antoine.gouby@toradex.com>

arm64: dts: freescale: imx95-aquila: Add Clover carrier board

This commit adds device tree support for the Aquila i.MX95 SoM mated with
the Clover carrier board. It configures basic interfaces including DP,
Ethernet, CAN, and the FlexSPI controller.

Link: https://www.toradex.com/computer-on-modules/aquila-arm-family/nxp-imx95
Link: https://www.toradex.com/products/carrier-board/clover

> diff --git a/arch/arm64/boot/dts/freescale/imx95-aquila-clover.dts b/arch/arm64/boot/dts/freescale/imx95-aquila-clover.dts
> new file mode 100644
> index 0000000000000..021d437763412
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-aquila-clover.dts

[ ... ]

> +/* Aquila QSPI_1 */
> +&flexspi1 {
> +	pinctrl-0 = <&pinctrl_flexspi1_4bit>,
> +		    <&pinctrl_qspi_cs1>;
> +
> +	status = "okay";
> +
> +	flash@0 {
> +		compatible = "jedec,spi-nor";
> +		reg = <0x0>;
> +		spi-max-frequency = <66000000>;
> +		spi-rx-bus-width = <4>;
> +		spi-tx-bus-width = <4>;
> +		cdns,read-delay = <0>;
> +		cdns,tchsh-ns = <3>;
> +		cdns,tsd2d-ns = <10>;
> +		cdns,tshsl-ns = <30>;
> +		cdns,tslch-ns = <8>;

[Severity: Low]
Are these cdns,* properties intended for the NXP FlexSPI controller?

The imx95 SoC utilizes the NXP FlexSPI controller, but these cdns properties
are specific to the Cadence QSPI driver. The NXP FlexSPI driver does not
parse or support any cdns,* properties, so these timing configurations will
be silently ignored by the kernel.

> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520-add-aquila-imx95-v2-0-06424a51e33a@toradex.com?part=3