Re: [PATCH v5 1/2] dt-bindings: ti: Update audio-refclk binding and j721e system controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Standard `clock@...` node names for the audio reference clock will fail validation because they will match the existing SERDES control pattern in `ti,j721e-system-controller.yaml`.
--

commit e99145dc81945477b02ec4f36bbd799351ed4236
Author: Moteen Shah <m-shah@ti.com>

dt-bindings: ti: Update audio-refclk binding and j721e system controller

This commit adds ti,j721s2-audio-refclk as a supported compatible string
in the ti,am62-audio-refclk binding. It also extends the
ti,j721e-system-controller clock-controller@ child pattern to accept
audio-refclk schemas alongside ehrpwm-tbclk.

> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
> index f3bd0be3b279f..364be49f8c7c7 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,j721e-system-controller.yaml

[ ... ]

> @@ -53,9 +53,11 @@ patternProperties:
>  
>    "^clock-controller@[0-9a-f]+$":
>      type: object
> -    $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
> +    oneOf:
> +      - $ref: /schemas/clock/ti,am62-audio-refclk.yaml#
> +      - $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
>      description:
> -      Clock provider for TI EHRPWM nodes.
> +      Clock provider for TI EHRPWM or Audio Reference Clock nodes.

[Severity: Medium]
Does placing the audio reference clock schema under the
clock-controller@... pattern force device tree authors to use that specific
node name to pass validation?

In ti,j721e-system-controller.yaml, the ^clock@[0-9a-f]+$ pattern is strictly
bound to the SerDes control schema (ti,am654-serdes-ctrl.yaml).

If an author attempts to use the standard clock@... naming as demonstrated in
the ti,am62-audio-refclk.yaml example, does the node mistakenly trigger the
SerDes schema validation and fail, forcing an inconsistency in generic node
naming conventions?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520115603.2662930-1-m-shah@ti.com?part=1