Re: [PATCH v8 2/2] leds: ltc3220: Add Support for LTC3220 18 channel LED Driver

[Lee Jones <lee@kernel.org>]

On Wed, 20 May 2026, Escala, Edelweise wrote:

> 
> > -----Original Message-----
> > From: sashiko-bot@kernel.org <sashiko-bot@kernel.org>

Do I need to sign-up to receive these?

> > Sent: Tuesday, May 19, 2026 9:50 AM
> > To: Escala, Edelweise <Edelweise.Escala@analog.com>
> > Cc: robh@kernel.org; devicetree@vger.kernel.org; conor+dt@kernel.org

Working why only these email addresses were Cc:ed.

> > Subject: Re: [PATCH v8 2/2] leds: ltc3220: Add Support for LTC3220 18 channel
> > LED Driver
> > 
> > [External]
> > 
> > Thank you for your contribution! Sashiko AI review found 7 potential issue(s) to
> > consider:
> > - [High] The driver abuses the `brightness` attribute to multiplex hardware modes,
> > violating standard LED UAPI.
> > - [High] The `blink_mode` value is not shifted before being written via
> > `regmap_update_bits()`, causing blink timing to fail.
> > - [High] `ltc3220_blink_set()` fails to enable blink mode on the target LED's
> > control register.
> > - [High] `ltc3220_pattern_clear()` incorrectly halts the global gradation timer and
> > fails to reset the individual LED mode.
> > - [High] Duplicate `reg` values in the device tree cause double-registration and list
> > corruption.
> > - [High] Missing `select REGMAP_I2C` in Kconfig leads to silent build failures.
> > - [Medium] Missing `led_classdev_suspend()` and `led_classdev_resume()` calls
> > during power management.
> > --
> > 
> > commit 0ef3ccbe351040b28172d9e382676a039d0118d4
> > Author: Edelweise Escala <edelweise.escala@analog.com>



-- 
Lee Jones